Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to prettier! #2038

Merged
merged 70 commits into from
Jun 3, 2019
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
6450d9c
Update eslint
May 23, 2019
06e10de
Move .prettierrc to each package
May 24, 2019
965ebb2
Prettier pass
May 24, 2019
c82af51
Localization cleanup
May 24, 2019
d549971
More Localization cleanup + prettier
May 29, 2019
f922192
post-prettier cleanup
May 29, 2019
6a8027d
Update CHANGELOG.md
May 29, 2019
d5e0755
Update CHANGELOG.md
May 29, 2019
3e9c673
Update /actionDispatched.js
corinagum May 30, 2019
ea529c8
Update packages/bundle/.eslintrc.yml
corinagum May 30, 2019
81d5433
Update submitSendBoxSaga.js
corinagum May 30, 2019
0130c58
Update getTimestamp.js
corinagum May 30, 2019
22fe7ba
Update sleep.js
corinagum May 30, 2019
4b2456b
Update concatMiddleware.js
corinagum May 30, 2019
d61fc2a
Update uniqueID.js
corinagum May 30, 2019
7f4d315
Update forkPut.js
corinagum May 30, 2019
3d4f05c
Update AudioAttachment.js
corinagum May 30, 2019
dc9eb01
Update AudioContent.js
corinagum May 30, 2019
d14dfdf
Update CarouselFilmStrip.js
corinagum May 30, 2019
6301a95
Update retry.js
corinagum May 30, 2019
64ca6c7
Update allImagesLoaded.js
corinagum May 30, 2019
7a37e29
Update AudioCardAttachment.js
corinagum May 30, 2019
1b8120d
Update debounce.js
corinagum May 30, 2019
4ef4e3e
Update CarouselFlipper.js
corinagum May 30, 2019
614c076
Update ConnectivityNotification.js
corinagum May 30, 2019
e5598f3
Update allOutgoingActivitiesSent.js
corinagum May 30, 2019
d3b2af2
Update directLineConnected.js
corinagum May 30, 2019
514351d
Update minNumActivitiesShown.js
corinagum May 30, 2019
188953d
Update suggestedActionsShowed.js
corinagum May 30, 2019
75ce669
Update __tests__/setup/conditions/uiConnected.js
corinagum May 30, 2019
4f8801b
Update setupTestEnvironment.js
corinagum May 30, 2019
a27123a
Update AnimationCardAttachment.js
corinagum May 30, 2019
f0fd319
Update DownloadAttachment.js
corinagum May 30, 2019
c88faed
Update ErrorNotification.js
corinagum May 30, 2019
5da043b
Update webChatLoaded.js
corinagum May 30, 2019
9db9473
Update /setup/pageObjects/index.js
corinagum May 30, 2019
88ba6e3
Update ScrollToEndButton.js
corinagum May 30, 2019
ed6842e
Update SendBoxButton.js
corinagum May 30, 2019
a21c247
Update SpinnerAnimation.js
corinagum May 30, 2019
06ef5b1
Update StackedLayout.js
corinagum May 30, 2019
a36277f
Update TextContent.js
corinagum May 30, 2019
0d7c1b3
Update TypingActivity.js
corinagum May 30, 2019
f237c2d
Update TypingAnimation.js
corinagum May 30, 2019
f8bb2ea
Update VideoAttachment.js
corinagum May 30, 2019
42434fe
Update VideoContent.js
corinagum May 30, 2019
d9c4120
Update VimeoContent.js
corinagum May 30, 2019
bcdca4b
Update WarningNotification.js
corinagum May 30, 2019
b9bb884
Update StyleSet/YouTubeContent.js
corinagum May 30, 2019
66bc7b4
Update Utils/debounce.js
corinagum May 30, 2019
28d0698
Update Utils/shallowEquals.js
corinagum May 30, 2019
64246e9
Update textFormatToContentType.js
corinagum May 30, 2019
da1a33e
Update connectionStatusUpdate.js
corinagum May 30, 2019
005ddf4
Update deleteActivity.js
corinagum May 30, 2019
bd8ec7f
Update disconnect.js
corinagum May 30, 2019
1f9e42e
Update incomingActivity.js
corinagum May 30, 2019
467410c
Update packages/core/src/actions/postActivity.js
corinagum May 30, 2019
f8880f5
Update packages/core/src/actions/sagaError.js
corinagum May 30, 2019
3e35790
Update packages/core/src/actions/setDictateInterims.js
corinagum May 30, 2019
3830db7
Update packages/core/src/actions/setDictateState.js
corinagum May 30, 2019
8db7bfa
Update packages/core/src/actions/setSendBox.js
corinagum May 30, 2019
359341e
Update packages/core/src/actions/setSendTyping.js
corinagum May 30, 2019
a0dca38
Update packages/core/src/actions/setSendTypingIndicator.js
corinagum May 30, 2019
cab0905
Update packages/core/src/actions/startDictate.js
corinagum May 30, 2019
3229048
Update packages/core/src/actions/stopDictate.js
corinagum May 30, 2019
961a9ac
Apply function names from code review
corinagum May 30, 2019
6baf89e
Linting after PR Fixes
Jun 3, 2019
6386e6c
Remove .md files from prettier and add manual .md file command
Jun 3, 2019
834b6e1
Remove timestamp from localization params
Jun 3, 2019
e7b791d
Fix merge conflict on CHANGELOG.md
Jun 3, 2019
a4d2878
Ignore md files in lint-staged
Jun 3, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 5 additions & 5 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ rules:
- allow:
- error
- warn
no-extra-parens: error
# no-extra-parens: error # conflicts with prettier
no-misleading-character-class: error
no-template-curly-in-string: error
require-atomic-updates: error
Expand Down Expand Up @@ -138,9 +138,9 @@ rules:
- error
- after: true
before: true
generator-star-spacing:
- error
- after
# generator-star-spacing: # conflicts with prettier
# - error
# - after
corinagum marked this conversation as resolved.
Show resolved Hide resolved

# Will produce shorter code if "off"
# no-confusing-arrow:
Expand Down Expand Up @@ -173,7 +173,7 @@ rules:

template-curly-spacing:
- error
- always
- never
yield-star-spacing:
- error
- after
Expand Down
6 changes: 3 additions & 3 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Contributing

This project welcomes contributions and suggestions. Most contributions require you to agree to a
This project welcomes contributions and suggestions. Most contributions require you to agree to a
Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us
the rights to use your contribution. For details, visit https://cla.microsoft.com.

Expand All @@ -27,10 +27,10 @@ npm run build
There are 3 types of build tasks in the build process.

- `npm run build`: Build for development (instrumented code for code coverage)
- Will bundle as `webchat-instrumented*.js`
- Will bundle as `webchat-instrumented*.js`
- `npm run watch`: Build for development with watch mode loop
- `npm run prepublishOnly`: Build for production
- Will bundle as `webchat*.js`
- Will bundle as `webchat*.js`

## Testing Web Chat for development purpose

Expand Down
7 changes: 7 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG.md
Original file line number Diff line number Diff line change
@@ -1,28 +1,35 @@
### [GitHub issues](https://github.com/Microsoft/botframework-webchat/issues) should be used for bugs and feature requests. See the Support section to get support related to Bot Framework and Web Chat.

## Screenshots

<!-- If applicable, add screenshots to help explain your problem. -->
<!-- Be sure to remove or obscure personally identifiable information from your code and screenshots -->

## Version

<!-- What version of Web Chat are you using? Are you using the CDN? NPM package? Or embedding Web Chat to your site via `<iframe>`? -->
<!-- The fastest way to find your Web Chat version is by checking the meta tag on your deployed site. -->

## Describe the bug

<!-- Give a clear and concise description of what the bug is. -->
<!-- Please be sure to add screenshots of the console errors in your browser, if there are any -->

## To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

## Expected behavior

<!-- Give a clear and concise description of what you expect to happen when following the reproduction steps above. -->

## Additional context

<!-- Add any other context about the problem here.-->

[Bug]
5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/FEATURE-REQUEST.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,23 @@
## Feature Request

### Use the ['Enhancement' query](https://github.com/Microsoft/botframework-Webchat/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3Aenhancement) to search for the most popular feature requests.

### The [Sample tag](https://github.com/Microsoft/botframework-Webchat/issues?q=is%3Aissue+is%3Aopen+label%3ASample) also lists examples and implementations that have already been requested.

**Is your feature request related to a problem? Please describe.**

<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->

**Describe the suggestion or request in detail**

<!-- A clear and concise description of what you want to happen. -->

**Describe alternatives you have considered**

<!-- A clear and concise description of any alternative solutions or features you've considered. -->

**Additional context**

<!-- Add any other context or screenshots about the feature request here. -->

[Enhancement]
2 changes: 0 additions & 2 deletions .github/ISSUE_TEMPLATE/QUESTION.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@

🚨 The issue tracker is not for implementation questions 🚨

<!-- If you have other questions on implementation of Web Chat or about other features of Bot Framework, please see the support page on where to direct your question. -->


[Question]
12 changes: 9 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,37 +1,43 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
title: ""
labels: Bug, Pending
assignees: ''

assignees: ""
---

### [GitHub issues](https://github.com/Microsoft/botframework-webchat/issues) should be used for bugs and feature requests. See the Support section to get support related to Bot Framework and Web Chat.

## Screenshots

<!-- If applicable, add screenshots to help explain your problem. -->
<!-- Be sure to remove or obscure personally identifiable information from your code and screenshots -->

## Version

<!-- What version of Web Chat are you using? Are you using the CDN? NPM package? Or embedding Web Chat to your site via `<iframe>`? -->
<!-- The fastest way to find your Web Chat version is by checking the meta tag on your deployed site. -->

## Describe the bug

<!-- Give a clear and concise description of what the bug is. -->
<!-- Please be sure to add screenshots of the console errors in your browser, if there are any -->

## To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

## Expected behavior

<!-- Give a clear and concise description of what you expect to happen when following the reproduction steps above. -->

## Additional context

<!-- Add any other context about the problem here.-->

[Bug]
10 changes: 7 additions & 3 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,31 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
title: ""
labels: Enhancement, Pending
assignees: ''

assignees: ""
---

## Feature Request

### Use the ['Enhancement' query](https://github.com/Microsoft/botframework-Webchat/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3Aenhancement) to search for the most popular feature requests.

### The [Sample tag](https://github.com/Microsoft/botframework-Webchat/issues?q=is%3Aissue+is%3Aopen+label%3ASample) also lists examples and implementations that have already been requested.

**Is your feature request related to a problem? Please describe.**

<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->

**Describe the suggestion or request in detail**

<!-- A clear and concise description of what you want to happen. -->

**Describe alternatives you have considered**

<!-- A clear and concise description of any alternative solutions or features you've considered. -->

**Additional context**

<!-- Add any other context or screenshots about the feature request here. -->

[Enhancement]
6 changes: 2 additions & 4 deletions .github/ISSUE_TEMPLATE/question-template.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
---
name: Question template
about: Ask a question not related to implementation here
title: ''
title: ""
labels: Pending, Question
assignees: ''

assignees: ""
---

🚨 The issue tracker is not for implementation questions 🚨

<!-- If you have other questions on implementation of Web Chat or about other features of Bot Framework, please see the support page on where to direct your question. -->


[Question]
9 changes: 5 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
Fixes #<!-- If this addresses a specific issue, please provide the issue number here -->

## Changelog Entry

<!-- Please paste your new entry from CHANGELOG.MD here -->

## Description

<!-- Please discuss the changes you have worked on. What do the changes do; why is this PR needed? -->

## Specific Changes

<!-- Please list the changes in a concise manner. -->

-
-
-
---

- [ ] Testing Added
<!-- If you are adding a new feature to a library, you must include tests for your new code. -->
<!-- If you are adding a new feature to a library, you must include tests for your new code. -->
2 changes: 1 addition & 1 deletion .github/SUPPORT.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
This repo focuses on the development of Web Chat, a client/channel for Bot Framework. We welcome feature requests and bug reports related to Web Chat. If you have other questions on implementation or about other features of Bot Framework, please see the below list to direct your questions to the correct repo or site.

| Topic | Description | Link |
|-----------------------------|--------------------------------------------------------------|---------------------------------------------------------|
| --------------------------- | ------------------------------------------------------------ | ------------------------------------------------------- |
| Web Chat 'How to' Questions | Ask implementation questions about Web Chat | https://stackoverflow.com/questions/tagged/web-chat |
| Bot Framework Questions | Ask implementation questions related to the BotFramework SDK | https://stackoverflow.com/questions/tagged/botframework |
| Bot Builder | A comprehensive list of Bot Framework SDKs and tools | https://github.com/Microsoft/BotBuilder |
Loading