Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type of button to scrollToEndButton #1743

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

corinagum
Copy link
Contributor

Fix #1741

Not having type="button" defaults the type to submit, which is causing a page refresh when scrollToEndButton is clicked.

@coveralls
Copy link

coveralls commented Feb 19, 2019

Coverage Status

Coverage decreased (-0.8%) to 55.227% when pulling 934aff8 on corinagum:corinagum/1741 into 25b2c47 on Microsoft:master.

@corinagum corinagum merged commit c3b2a6d into microsoft:master Feb 20, 2019
compulim pushed a commit to compulim/BotFramework-WebChat that referenced this pull request Feb 20, 2019
* Add type of button to scrollToEndButton

* Update CHANGELOG.md
corinagum pushed a commit that referenced this pull request Feb 20, 2019
* Add type of button to scrollToEndButton

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants