-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ponyfilling window.open #368
Comments
is it Title or "specs" |
I was going by the TypeScript, but even then I got it wrong: Window.open(url?: string, target?: string, features?: string, replace?: boolean): Window |
compulim
pushed a commit
to compulim/BotFramework-WebChat
that referenced
this issue
Jul 14, 2018
corinagum
added
4.3
p1
Painful if we don't fix, won't block releasing
and removed
4.2
labels
Nov 27, 2018
corinagum
added
p0
Must Fix. Release-blocker
front-burner
and removed
p1
Painful if we don't fix, won't block releasing
labels
Nov 28, 2018
Related to #1504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we call
window.open(url)
for card actions. The default in most browsers is to open the url in a new tab, but some might like to open it in a new window, etc.My proposal is to add
urlTarget?:string
andurlTitle?:string
toChatProps
. If supplied we'd pass them as the second and third parameter towindow.open
.The text was updated successfully, but these errors were encountered: