Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mic not highlighted #3265

Closed
prashanthsridhar opened this issue Jun 19, 2020 · 3 comments · Fixed by #3276 or #3304
Closed

Mic not highlighted #3265

prashanthsridhar opened this issue Jun 19, 2020 · 3 comments · Fixed by #3276 or #3304
Assignees
@corinagum
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@prashanthsridhar
Copy link

Screenshots

image

Version

4.9.1 CDN

Describe the bug

The mic generally turns red when listening. It was doing that in 4.8.0 but now it is not.

Steps to reproduce

click on mic icon

Expected behavior

mic turns red
image

Additional context

Implemented in an angular project

[Bug]
@prashanthsridhar prashanthsridhar added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Jun 19, 2020
@srinaath
Copy link

@corinagum could you take a look at this issue if its a regression?

@srinaath srinaath added the customer-replied-to Required for internal reporting. Do not delete. label Jun 22, 2020
@corinagum
Copy link
Contributor

corinagum commented Jun 23, 2020 •
edited
Loading

Hmmm I'm repro-ing this problem but not consistently.

  1. not caused by type of package (cdn/npm)
  2. different samples behave differently
  3. same samples behave differently across browsers
  4. red will show once but not after a repeat usage

Investigating further

So far I think the main issue is the last item.

@corinagum corinagum added the needs-repro Waiting for repro or investigation label Jun 23, 2020
@corinagum corinagum removed the needs-repro Waiting for repro or investigation label Jun 23, 2020
@corinagum
Copy link
Contributor

This is due to a styling specificity regression - fix will be up shortly.

@corinagum corinagum mentioned this issue Jun 23, 2020
Merged
1 task
corinagum added a commit that referenced this issue Jun 24, 2020
@corinagum
#3265 Fix microphone button styling regression (#3276)
0911f3d 
* Fix microphone button styling regression

* Update CHANGELOG.md
@compulim compulim mentioned this issue Jul 13, 2020
Closed
42 tasks
@corinagum corinagum mentioned this issue Jul 14, 2020
Merged
@compulim compulim added the R10 label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Milestone
No milestone
4 participants
@compulim @prashanthsridhar @srinaath @corinagum