Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested actions are not spoken #1780

Closed
leolorenzoluis opened this issue Mar 4, 2019 · 9 comments · Fixed by #2613
Closed

Suggested actions are not spoken #1780

leolorenzoluis opened this issue Mar 4, 2019 · 9 comments · Fixed by #2613
Assignees
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing

Comments

@leolorenzoluis
Copy link

Given the server returns a reply that has SuggestedActions with Speak property populated. The WebChat wouldn't speak the given reply by the server.

@corinagum corinagum added front-burner Pending needs-repro Waiting for repro or investigation labels Mar 13, 2019
@corinagum
Copy link
Contributor

According to the documentation, there is no Speak property on the Suggested Actions schema.

Could you recommend scenarios where the Speak property is necessary? If so, this will help us to plan for this feature.

@leolorenzoluis
Copy link
Author

Accessibility. What if the person can't see and only interacts based on what he hears?

@corinagum
Copy link
Contributor

corinagum commented Mar 25, 2019

thank you! I think I closed this on accident last week so I'm going to keep it open for discussion with the dev team.

We need to ensure the Narrator speaks suggested actions - we will not support the Speak property unless there is a change to the schema.

@corinagum corinagum added p1 Painful if we don't fix, won't block releasing 4.5 labels Mar 25, 2019
@corinagum
Copy link
Contributor

We need to add aria-live to the suggested-actions buttons. We'll fix this targeting for 4.5

@leolorenzoluis
Copy link
Author

Will adding the aria tag make the bot speak without using accessibility tools?

@compulim
Copy link
Contributor

compulim commented Apr 1, 2019

No, aria-live tag only works with changing content. But not initial content.

Today, we add a box (element) around suggested actions when we need to show them up. We remove the element when there are no suggested actions.

We cannot simply add aria-live tag in that box, because it is not "changing content", it is "creating a new element". And aria-live will not speak out when the element is new.

So, we need to have the box persisted on Web Chat UI, and change its content from time to time.

On the other side, while we are experimenting with aria-live region, we found that a page with multiple aria-live regions may conflict with each other. So if it doesn't work (multiple aria-live regions in a our setup), then, we might need a bigger change on DOM structure to make it work.

@corinagum corinagum added backlog Out of scope for the current iteration but it will be evaluated in a future release. and removed 4.5 labels Apr 2, 2019
@corinagum corinagum added 4.6 and removed backlog Out of scope for the current iteration but it will be evaluated in a future release. labels Jul 10, 2019
@corinagum corinagum self-assigned this Jul 10, 2019
@Kaiqb Kaiqb added the Customer label Jul 23, 2019
@sgellock sgellock removed the Customer label Aug 8, 2019
@corinagum corinagum removed the needs-repro Waiting for repro or investigation label Sep 6, 2019
@cwhitten cwhitten removed the 4.6 label Sep 25, 2019
@corinagum corinagum added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Sep 25, 2019
@cwhitten cwhitten added the R7 label Nov 7, 2019
@corinagum corinagum added the bug Indicates an unexpected problem or an unintended behavior. label Nov 7, 2019
@corinagum corinagum added front-burner and removed backlog Out of scope for the current iteration but it will be evaluated in a future release. front-burner Triage-E labels Nov 7, 2019
@compulim
Copy link
Contributor

More clarifications over my previous comment.

I think role="status" is conflicting with aria-live="polite". But as @corinagum pointed out, two aria-live="polite" should not conflict with each others.

corinagum added a commit to corinagum/BotFramework-WebChat that referenced this issue Nov 19, 2019
@leolorenzoluis
Copy link
Author

Just following up, does this mean the app will need a narrator in order for the person to hear what the bot says? It still won't speak the first time it starts a conversation?

@corinagum
Copy link
Contributor

This issue is in regards to the accessibility of Suggested Actions. Yes, customers will need an Assistive Technology to be alerted of a change in Suggested Actions. This is not related to speech. As discussed above, Suggested Actions to not have a speak property and therefore will not be spoken by the (speech) bot by design.

corinagum added a commit that referenced this issue Nov 20, 2019
* packages update

* Attachment aria-label fixes

* Fix arialabel for connectivity status & ea. bubble

* #1780 make Suggested Actions accessible

* Code cleanup

* Upload file string correction

* Update CHANGELOG.md

* Linting fixes

* Update packages/component/src/Utils/AbsoluteTime.js

Co-Authored-By: William Wong <compulim@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: William Wong <compulim@users.noreply.github.com>

* Apply PR comments
@corinagum corinagum mentioned this issue Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants