Skip to content

Commit

Permalink
Move to prettier! (#2038)
Browse files Browse the repository at this point in the history
* Update eslint

* Move .prettierrc to each package

* Prettier pass

* Localization cleanup

* More Localization cleanup + prettier

* post-prettier cleanup

* Update CHANGELOG.md

* Update /actionDispatched.js

* Remove .md files from prettier and add manual .md file command

* Remove timestamp from localization params

* Ignore .md files in lint-staged
  • Loading branch information
corinagum authored Jun 3, 2019
1 parent 7c3f47b commit a10096a
Show file tree
Hide file tree
Showing 364 changed files with 5,186 additions and 5,124 deletions.
10 changes: 5 additions & 5 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ rules:
- allow:
- error
- warn
no-extra-parens: error
# no-extra-parens: error # conflicts with prettier
no-misleading-character-class: error
no-template-curly-in-string: error
require-atomic-updates: error
Expand Down Expand Up @@ -138,9 +138,9 @@ rules:
- error
- after: true
before: true
generator-star-spacing:
- error
- after
# generator-star-spacing: # conflicts with prettier
# - error
# - after

# Will produce shorter code if "off"
# no-confusing-arrow:
Expand Down Expand Up @@ -173,7 +173,7 @@ rules:

template-curly-spacing:
- error
- always
- never
yield-star-spacing:
- error
- after
Expand Down
16 changes: 8 additions & 8 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Contributing

This project welcomes contributions and suggestions. Most contributions require you to agree to a
This project welcomes contributions and suggestions. Most contributions require you to agree to a
Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us
the rights to use your contribution. For details, visit https://cla.microsoft.com.

Expand All @@ -26,11 +26,11 @@ npm run build

There are 3 types of build tasks in the build process.

- `npm run build`: Build for development (instrumented code for code coverage)
- Will bundle as `webchat-instrumented*.js`
- `npm run watch`: Build for development with watch mode loop
- `npm run prepublishOnly`: Build for production
- Will bundle as `webchat*.js`
- `npm run build`: Build for development (instrumented code for code coverage)
- Will bundle as `webchat-instrumented*.js`
- `npm run watch`: Build for development with watch mode loop
- `npm run prepublishOnly`: Build for production
- Will bundle as `webchat*.js`

## Testing Web Chat for development purpose

Expand All @@ -43,8 +43,8 @@ npm start

Then browse to http://localhost:3000/, and click on one of the connection options on the upper right corner.

- Official MockBot: we hosted a live demo bot for testing Web Chat features
- Emulator Core: it will connect to http://localhost:5000/v3/directline for [emulated Direct Line service](https://github.com/Microsoft/BotFramework-Emulator/tree/master/packages/emulator/cli/)
- Official MockBot: we hosted a live demo bot for testing Web Chat features
- Emulator Core: it will connect to http://localhost:5000/v3/directline for [emulated Direct Line service](https://github.com/Microsoft/BotFramework-Emulator/tree/master/packages/emulator/cli/)

You are also advised to test the CDN bundles by copying the test harness from our samples.

Expand Down
7 changes: 7 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG.md
Original file line number Diff line number Diff line change
@@ -1,28 +1,35 @@
### [GitHub issues](https://github.com/Microsoft/botframework-webchat/issues) should be used for bugs and feature requests. See the Support section to get support related to Bot Framework and Web Chat.

## Screenshots

<!-- If applicable, add screenshots to help explain your problem. -->
<!-- Be sure to remove or obscure personally identifiable information from your code and screenshots -->

## Version

<!-- What version of Web Chat are you using? Are you using the CDN? NPM package? Or embedding Web Chat to your site via `<iframe>`? -->
<!-- The fastest way to find your Web Chat version is by checking the meta tag on your deployed site. -->

## Describe the bug

<!-- Give a clear and concise description of what the bug is. -->
<!-- Please be sure to add screenshots of the console errors in your browser, if there are any -->

## To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

## Expected behavior

<!-- Give a clear and concise description of what you expect to happen when following the reproduction steps above. -->

## Additional context

<!-- Add any other context about the problem here.-->

[Bug]
5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/FEATURE-REQUEST.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,23 @@
## Feature Request

### Use the ['Enhancement' query](https://github.com/Microsoft/botframework-Webchat/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3Aenhancement) to search for the most popular feature requests.

### The [Sample tag](https://github.com/Microsoft/botframework-Webchat/issues?q=is%3Aissue+is%3Aopen+label%3ASample) also lists examples and implementations that have already been requested.

**Is your feature request related to a problem? Please describe.**

<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->

**Describe the suggestion or request in detail**

<!-- A clear and concise description of what you want to happen. -->

**Describe alternatives you have considered**

<!-- A clear and concise description of any alternative solutions or features you've considered. -->

**Additional context**

<!-- Add any other context or screenshots about the feature request here. -->

[Enhancement]
2 changes: 0 additions & 2 deletions .github/ISSUE_TEMPLATE/QUESTION.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@

🚨 The issue tracker is not for implementation questions 🚨

<!-- If you have other questions on implementation of Web Chat or about other features of Bot Framework, please see the support page on where to direct your question. -->


[Question]
8 changes: 7 additions & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,34 +4,40 @@ about: Create a report to help us improve
title: ''
labels: Bug, Pending
assignees: ''

---

### [GitHub issues](https://github.com/Microsoft/botframework-webchat/issues) should be used for bugs and feature requests. See the Support section to get support related to Bot Framework and Web Chat.

## Screenshots

<!-- If applicable, add screenshots to help explain your problem. -->
<!-- Be sure to remove or obscure personally identifiable information from your code and screenshots -->

## Version

<!-- What version of Web Chat are you using? Are you using the CDN? NPM package? Or embedding Web Chat to your site via `<iframe>`? -->
<!-- The fastest way to find your Web Chat version is by checking the meta tag on your deployed site. -->

## Describe the bug

<!-- Give a clear and concise description of what the bug is. -->
<!-- Please be sure to add screenshots of the console errors in your browser, if there are any -->

## To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

## Expected behavior

<!-- Give a clear and concise description of what you expect to happen when following the reproduction steps above. -->

## Additional context

<!-- Add any other context about the problem here.-->

[Bug]
6 changes: 5 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,28 @@ about: Suggest an idea for this project
title: ''
labels: Enhancement, Pending
assignees: ''

---

## Feature Request

### Use the ['Enhancement' query](https://github.com/Microsoft/botframework-Webchat/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3Aenhancement) to search for the most popular feature requests.

### The [Sample tag](https://github.com/Microsoft/botframework-Webchat/issues?q=is%3Aissue+is%3Aopen+label%3ASample) also lists examples and implementations that have already been requested.

**Is your feature request related to a problem? Please describe.**

<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->

**Describe the suggestion or request in detail**

<!-- A clear and concise description of what you want to happen. -->

**Describe alternatives you have considered**

<!-- A clear and concise description of any alternative solutions or features you've considered. -->

**Additional context**

<!-- Add any other context or screenshots about the feature request here. -->

[Enhancement]
2 changes: 0 additions & 2 deletions .github/ISSUE_TEMPLATE/question-template.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@ about: Ask a question not related to implementation here
title: ''
labels: Pending, Question
assignees: ''

---

🚨 The issue tracker is not for implementation questions 🚨

<!-- If you have other questions on implementation of Web Chat or about other features of Bot Framework, please see the support page on where to direct your question. -->


[Question]
11 changes: 6 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
Fixes #<!-- If this addresses a specific issue, please provide the issue number here -->

## Changelog Entry

<!-- Please paste your new entry from CHANGELOG.MD here -->

## Description

<!-- Please discuss the changes you have worked on. What do the changes do; why is this PR needed? -->

## Specific Changes

<!-- Please list the changes in a concise manner. -->

-
-
-
---

- [ ] Testing Added
<!-- If you are adding a new feature to a library, you must include tests for your new code. -->
- [ ] Testing Added
<!-- If you are adding a new feature to a library, you must include tests for your new code. -->
2 changes: 1 addition & 1 deletion .github/SUPPORT.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
This repo focuses on the development of Web Chat, a client/channel for Bot Framework. We welcome feature requests and bug reports related to Web Chat. If you have other questions on implementation or about other features of Bot Framework, please see the below list to direct your questions to the correct repo or site.

| Topic | Description | Link |
|-----------------------------|--------------------------------------------------------------|---------------------------------------------------------|
| --------------------------- | ------------------------------------------------------------ | ------------------------------------------------------- |
| Web Chat 'How to' Questions | Ask implementation questions about Web Chat | https://stackoverflow.com/questions/tagged/web-chat |
| Bot Framework Questions | Ask implementation questions related to the BotFramework SDK | https://stackoverflow.com/questions/tagged/botframework |
| Bot Builder | A comprehensive list of Bot Framework SDKs and tools | https://github.com/Microsoft/BotBuilder |
Loading

0 comments on commit a10096a

Please sign in to comment.