Skip to content

Commit

Permalink
Cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
compulim committed Mar 25, 2022
1 parent 7034f36 commit 2c4b65c
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import { hooks } from 'botframework-webchat-api';
import { useMemo } from 'react';

import type { WebChatActivity } from 'botframework-webchat-core';

import intersectionOf from '../../../Utils/intersectionOf';
import removeInline from '../../../Utils/removeInline';

import type { ActivityWithRenderer, ReadonlyActivityTree } from './types';

const { useGroupActivities } = hooks;
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/reducers/activities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { INCOMING_ACTIVITY } from '../actions/incomingActivity';
import { MARK_ACTIVITY } from '../actions/markActivity';
import { POST_ACTIVITY_FULFILLED, POST_ACTIVITY_PENDING, POST_ACTIVITY_REJECTED } from '../actions/postActivity';
import { SEND_FAILED, SENDING, SENT } from '../constants/ActivityClientState';

import type { DeleteActivityAction } from '../actions/deleteActivity';
import type { IncomingActivityAction } from '../actions/incomingActivity';
import type { MarkActivityAction } from '../actions/markActivity';
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/sagas/postActivitySaga.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import sendTimeoutSelector from '../selectors/sendTimeout';
import sleep from '../utils/sleep';
import uniqueID from '../utils/uniqueID';
import whileConnected from './effects/whileConnected';

import type { DirectLineActivity } from '../types/external/DirectLineActivity';
import type { DirectLineJSBotConnection } from '../types/external/DirectLineJSBotConnection';
import type { IncomingActivityAction } from '../actions/incomingActivity';
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/types/external/DirectLineActivity.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// TODO: [P1] #3953 We should fully type it out.

type DirectLineActivity = any;
// Until we fully typed out DirectLineActivity, we need to use "any" here.
// We only know the DirectLineActivity must be a map, and not other primitive types.
type DirectLineActivity = Exclude<any, [] | boolean | Function | number | string>;

export type { DirectLineActivity };

0 comments on commit 2c4b65c

Please sign in to comment.