Incorp PR changes

microsoft · Jun 16, 2022 · 1287624 · 1287624
1 parent 48a0af5
commit 1287624
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/component/src/LiveRegion/LiveRegionActivity.tsx b/packages/component/src/LiveRegion/LiveRegionActivity.tsx
@@ -66,7 +66,7 @@ const LiveRegionActivity: VFC<LiveRegionActivityProps> = ({ activity, id }) => {
     return activityKey && `webchat__live-region-activity__label-${activityKey}`;
   }, [activity, getKeyByActivity]);
 
-  // TODO: [P0] Investigate: this section seems to be narrated 2 times by some screen readers.
+  // TODO: [P0] #4294 Investigate: this section seems to be narrated 2 times by some screen readers.
   return (
     <article
       aria-atomic={true}

diff --git a/packages/component/src/LiveRegion/private/LiveRegionAttachments.tsx b/packages/component/src/LiveRegion/private/LiveRegionAttachments.tsx
@@ -26,7 +26,7 @@ const LiveRegionAttachments: VFC<LiveRegionAttachmentsProps> = ({ activity }) =>
 
   const attachmentForScreenReaderRenderers = attachments
     .map(attachment => createAttachmentForScreenReaderRenderer({ activity, attachment }))
-    .filter(render => render);
+    .filter(Boolean);
 
   const numGenericAttachments = attachments.length - attachmentForScreenReaderRenderers.length;
 

diff --git a/packages/component/src/SendBox/SuggestedActions.tsx b/packages/component/src/SendBox/SuggestedActions.tsx
@@ -214,7 +214,7 @@ const SuggestedActions: FC<SuggestedActionsProps> = ({ className, suggestedActio
   const [{ suggestedActionLayout, suggestedActionsStackedLayoutButtonTextWrap }] = useStyleOptions();
   const localize = useLocalizer();
 
-  // TODO: [P1] Clean up this one so screen reader will narrate something similar to "suggested actions toolbar".
+  // TODO: [P1] #4315 Clean up this one so screen reader will narrate something similar to "suggested actions toolbar".
   const screenReaderText = localize('SUGGESTED_ACTIONS_ALT', '');
 
   const children = suggestedActions.map((cardAction, index) => {

diff --git a/packages/component/src/Transcript/LiveRegionTranscript.tsx b/packages/component/src/Transcript/LiveRegionTranscript.tsx
@@ -90,7 +90,7 @@ const LiveRegionTranscriptCore: FC<LiveRegionTranscriptCoreProps> = ({ activityE
       typistNames[0]
     );
 
-  // TODO: [P*] We should change the narration to "Message has suggested actions. Press SHIFT + ALT + A to select them."
+  // TODO: [P1] #4315 We should change the narration to "Message has suggested actions. Press SHIFT + ALT + A to select them."
   const liveRegionSuggestedActionsLabelAlt = localize(
     'SUGGESTED_ACTIONS_ALT',
     accessKey