Fixed issue with websocket connections being closed when deep linking … #2146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…into a conversation.
===
Fixes #2144
===
This issue was a Windows-only (possibly Linux as well) bug that was happening due to the following:
ready-to-show
event is fired, and so before the WebSocket server is initializedready-to-show
browser window event is then fired and the web socket server is re-initialized which then callscleanup()
, closing the previously connected websocket for the running conversation===
This PR fixes that issue by changing the websocket server logic to only initialize the server once and return the port, instead of re-initializing if already running.
This means that the second call to
WebSocketServer.init()
in step 6 above results in a no-op and instead just returns the websocket server port.===
This does not occur on Mac because the protocol URLs are parsed and executed after the initial setup of the websocket server inside of the
ready-to-show
browser window event handler