[#1905] Fixed a11y issue with narration of checkboxes. #2010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1905
===
Made minor changes to the
<Checkbox />
component DOM structure.The previous structure wrapped the
<input>
in a<label>
element, and also attached anaria-label
attribute to the input. This caused screen readers to narrate both thearia-label
and the text within thelabel
element.I have changed the outer element to be a
<div>
with arole
or"presentation"
so that the screen reader ignores it, and I've wrapped the inner label text in a<label>
tag so that the component follows the standard semantic structure of a labelled checkbox input. I've also removed thearia-label
attribute from the<input>
element, because the screen reader should know that the<label>
tag describes the<input>
.I've tested this on both Windows, and Mac, and they read correctly.
Before:
After: