[#1906] Fixed bugs within connected service editor. #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
tonyanziano
force-pushed
the
toanzian/acc-#1906
branch
from
64dfdaf to
a493304
Compare
corinagum
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1906
===
There was a bug in the
ConnectedServiceEditorcode that was causingbotframework-configto throw, which then broke the saga that originally opened the add service context menu. This subsequently broke all future interactions with the service sagas, preventing the context menu or service buttons from working anymore.I added code to initialize the QnA Maker service editor with a sample host name to satisfy
botframework-configand prevent the error from being thrown.There was also another bug where the
learnMoreLinkButtonfunction was being called like a getter even though it was a function, and so none of the service editors were actually rendering the learn more links, which is now fixed.