Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1900][MAS4.2.1][Screen reader-How to Build a Bot] In voiceover mode, the contents are announced as “1 of 2 plan “ and "2 of 2 review the bot" #1933

Merged
merged 4 commits into from
Oct 18, 2019
Merged

[ISSUE#1900][MAS4.2.1][Screen reader-How to Build a Bot] In voiceover mode, the contents are announced as “1 of 2 plan “ and "2 of 2 review the bot" #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c205d4a
Update how to build a bot steps styles to improve screen reader inter…
Oct 16, 2019
98e328d
Add testbullet style
Bill7zz Oct 17, 2019
cc1da7e
Fix step-container last child style
Bill7zz Oct 17, 2019
7ee586d
Fix test step bullet color
Bill7zz Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions packages/app/client/src/ui/editor/welcomePage/howToBuildABot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ export class HowToBuildABot extends React.Component<HowToBuildABotProps, {}> {
<div className={styles.stepIcon}>
<div className={styles.buildPlan01} />
</div>
<dl>
<dt>Plan:</dt>
<dd>
<div className={styles.stepSection}>
<p className={styles.stepHeader}>Plan:</p>
<p className={styles.stepContent}>
Review the bot&nbsp;
<LinkButton
ariaLabel={'Learn more about design guidelines.'}
Expand All @@ -66,16 +66,16 @@ export class HowToBuildABot extends React.Component<HowToBuildABotProps, {}> {
design guidelines
</LinkButton>{' '}
for best practices&nbsp;
</dd>
</dl>
</p>
</div>
</div>
<div className={styles.stepContainer}>
<div className={styles.stepIcon}>
<div className={styles.buildPlan02} />
</div>
<dl>
<dt>Build:</dt>
<dd>
<div className={styles.stepSection}>
<p className={styles.stepHeader}>Build:</p>
<p className={styles.stepContent}>
<LinkButton linkRole={true} onClick={this.onEmulatorToolsLinkClick}>
Download Command Line tools
</LinkButton>
Expand Down Expand Up @@ -114,16 +114,16 @@ export class HowToBuildABot extends React.Component<HowToBuildABotProps, {}> {
<LinkButton ariaLabel={'Learn more about Dispatch'} linkRole={true} onClick={this.onDispatchLinkClick}>
Dispatch
</LinkButton>
</dd>
</dl>
</p>
</div>
</div>
<div className={styles.stepContainer}>
<div className={styles.stepIcon}>
<div className={styles.buildPlan03} />
</div>
<dl>
<dt className={styles.testBullet}>Test:</dt>
<dd>
<div className={styles.stepSection}>
<p className={`${styles.stepHeader} ${styles.testBullet}`}>Test:</p>
<p className={styles.stepContent}>
Test with the&nbsp;
<LinkButton
ariaLabel={'Test your bot on the Emulator.'}
Expand All @@ -141,16 +141,16 @@ export class HowToBuildABot extends React.Component<HowToBuildABotProps, {}> {
>
Web Chat
</LinkButton>
</dd>
</dl>
</p>
</div>
</div>
<div className={styles.stepContainer}>
<div className={styles.stepIcon}>
<div className={styles.buildPlan04} />
</div>
<dl>
<dt>Publish:</dt>
<dd>
<div className={styles.stepSection}>
<p className={styles.stepHeader}>Publish:</p>
<p className={styles.stepContent}>
Publish directly to Azure or
<br />
Use&nbsp;
Expand All @@ -162,16 +162,16 @@ export class HowToBuildABot extends React.Component<HowToBuildABotProps, {}> {
Continuous Deployment
</LinkButton>
&nbsp;
</dd>
</dl>
</p>
</div>
</div>
<div className={styles.stepContainer}>
<div className={styles.stepIcon}>
<div className={styles.buildPlan05} />
</div>
<dl>
<dt>Connect:</dt>
<dd>
<div className={styles.stepSection}>
<p className={styles.stepHeader}>Connect:</p>
<p className={styles.stepContent}>
Connect to&nbsp;
<LinkButton
ariaLabel={'Learn more connecting to channels.'}
Expand All @@ -181,21 +181,21 @@ export class HowToBuildABot extends React.Component<HowToBuildABotProps, {}> {
channels
</LinkButton>
&nbsp;
</dd>
</dl>
</p>
</div>
</div>
<div className={styles.stepContainer}>
<div className={styles.stepIcon}>
<div className={styles.buildPlan06} />
</div>
<dl>
<dt>Evaluate:</dt>
<dd>
<div className={styles.stepSection}>
<p className={styles.stepHeader}>Evaluate:</p>
<p className={styles.stepContent}>
<LinkButton linkRole={true} onClick={this.onAnalyticsLinkClick}>
View analytics
</LinkButton>
</dd>
</dl>
</p>
</div>
</div>
</div>
</div>
Expand Down
18 changes: 10 additions & 8 deletions packages/app/client/src/ui/editor/welcomePage/welcomePage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,13 @@
}
}

dl {
.step-section {
border-left: 1px solid var(--welcome-how-to-border);
display: block;
margin: 0;
padding: 0 24px;

> dt::before {
> .step-header::after {
background-color: var(--welcome-page-bg);
border: 1px solid var(--welcome-how-to-border);
border-radius: 100%;
Expand All @@ -139,28 +139,30 @@
width: 11px;
}

> .test-bullet::before {
> .test-bullet::after {
background-color: var(--welcome-how-to-test);
}


> dt {
> .step-header {
display: block;
font-weight: 600;
font-size: 13px;
line-height: 18px;
padding: 0;
margin: 0;
}

> dd {
> .step-content {
font-size: 13px;
line-height: 18px;
margin-left: 0;
padding-bottom: 22px;
padding: 0 0 22px 0;
margin: 0;
}
}
}

.step-container:last-child dl {
.step-container:last-child .step-section {
border-left: 1px solid transparent;
}
}
Expand Down
3 changes: 3 additions & 0 deletions packages/app/client/src/ui/editor/welcomePage/welcomePage.scss.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ export const buildPlan03: string;
export const buildPlan04: string;
export const buildPlan05: string;
export const buildPlan06: string;
export const stepSection: string;
export const stepHeader: string;
export const testBullet: string;
export const stepContent: string;
export const spacing: string;
export const marginFix: string;
export const botInspectorHeaderContainer: string;