Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1834][MAS4.2.1] [Screen reader -Debug] In forward navigation NVDA is not reading the under JSON tab section controls information #1923

Merged

Conversation

denscollo
Copy link
Contributor

Solves #1834

Description

This pull request enables the NVDA to read the content of the JSON web viewer.

Changes made

  • Remove tab index from panel content to allow the Screen Reader to read the content of the JSON tree view.
    a
    The panel content had an attribute tabindex which causes conflicts with the screen reader navigation using the tab control.
    image

Test

We navigate through the component using the tab control and the NVDA read the information of the elements as we expected.
image

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 66.897% when pulling 00172c5 on fix/json-web-view-forward-navigation-screen-reader into a66f568 on master.

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it looks good!

@tonyanziano tonyanziano merged commit e174390 into master Oct 10, 2019
@tonyanziano tonyanziano deleted the fix/json-web-view-forward-navigation-screen-reader branch October 10, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants