Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1717] Update ActivityWrapper to be accessible #1916

Merged
merged 3 commits into from
Oct 7, 2019
Merged

[#1717] Update ActivityWrapper to be accessible #1916

merged 3 commits into from
Oct 7, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Oct 7, 2019 •
edited by tonyanziano
Loading

#1712 #1717

Selected activities will now be noted as checked when selected, and at the same time open the activity in the json viewer.

  • ActivityWrapper has been changed from button to checkbox, and tests have been updated.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.931% when pulling 434aff5 on corinagum/1712 into e848885 on master.

tonyanziano
tonyanziano approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tonyanziano tonyanziano merged commit c53ac1d into master Oct 7, 2019
@tonyanziano tonyanziano deleted the corinagum/1712 branch October 7, 2019 23:37
@tonyanziano tonyanziano changed the title [#1712] Update ActivityWrapper to be accessible [#1717] Update ActivityWrapper to be accessible Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corinagum @coveralls @tonyanziano