Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus color for checkbox & tab's close button #1902

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Oct 4, 2019

#1712
[bug]
image

image

This fixes the focus colors for the checkbox and tab's close button.
Modifications:

  • checkbox's checked and focused border is 2px solid #00BCF2
  • checkbox's unchecked and focused border is 2px solid --global-focus-outline-color
  • tab's close button's focused border is 1px solid --global-focus-outline-color

image
image

edit:
Forgot to check the other themes. They looked alright, but in the interest of consistency and contrast, I upped both dark and high-contrast themes to 2px border focus as well. See above for screencaps.

@coveralls
Copy link

coveralls commented Oct 4, 2019

Coverage Status

Coverage remained the same at 65.931% when pulling e7ebd9e on corinagum/1712 into 2eaf596 on master.

tonyanziano
tonyanziano previously approved these changes Oct 4, 2019
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Does this need to be applied to dark / high contrast as well? Or are those good.

@corinagum corinagum merged commit e848885 into master Oct 4, 2019
@tonyanziano tonyanziano deleted the corinagum/1712 branch October 4, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants