-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1802, #1803, #1804, #1876] Added HTML App Menu for Windows #1893
Conversation
e7a2b6a
to
89920ed
Compare
89920ed
to
e3dd231
Compare
8f07c4d
to
f0b1be2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome! I just left teeny comments.
I also tested this out with NVDA and everything seems to work awesome!
The only comment I have is that when using browse mode in the app menu, for example highlighting "Zoom in" under View, pressing escape, then Ctrl + LeftArrow
to highlight Conversation will say "Out of menu button menu button sub menu Conversation". I'm assuming this is because it's trying to highlight within the sub menu, rather than the top level, but that panel is disabled. I'm also not sure if this is something the a11y team would highlight as need to fix, but I thought I would mention it just in case.
f0b1be2
to
ef4b405
Compare
@corinagum Addressed your comments. Thanks for the note on the menu accessibility, I didn't even know you could use My thought is that we submit it as is, and then if the a11y team ends up dinging us for that, we can fix it. However, to my memory, I don't think they reported any issues involving |
#1876, #1802, #1803, #1804
===