Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1808, #1809, #1810] Fixed Bot Inspector docs page accessibility #1858

Merged
merged 1 commit into from
Sep 10, 2019
Merged

[#1808, #1809, #1810] Fixed Bot Inspector docs page accessibility #1858

merged 1 commit into from
Sep 10, 2019

Conversation

tonyanziano
Copy link
Contributor

#1808, #1809, #1810

===

Fixes:

  • Cutoff focus outline border on top-level links
  • Header semantics of generated Markdown page (h1's downgraded to h2's, h2's to h3's, now only one h1 on the page)
  • Using browse mode will no longer get stuck in the dialog host component and read "blank" repeatedly

image

image

@tonyanziano tonyanziano marked this pull request as ready for review September 10, 2019 19:23
@coveralls
Copy link

coveralls commented Sep 10, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 65.787% when pulling 65bf397 on toanzian/acc-#1808-10 into 7c9e2bd on master.

corinagum
corinagum previously approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@tonyanziano tonyanziano merged commit d9ab68a into master Sep 10, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1808-10 branch September 10, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyanziano @coveralls @corinagum