Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1723, #1725, #1726, #1727, #1729] Fixed various dialog accessibility issues. #1828

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Sep 4, 2019

#1723, #1725, #1726, #1727, #1729

===

Fixed the following issues within dialogs:

  • the open bot dialog will no longer appear to lose focus after tabbing away from the "Browse" button
  • pressing "Escape" while using the autocomplete control in the open bot dialog will no longer close the dialog
  • there is now a focus indicator surrounding the close button on all dialogs
  • pressing "Escape" after opening the native file browse dialog using the "Browse" button will no longer close the dialog
  • fixed color contrast ratio for links within dialogs

Close icon focus indicator:

image

"Learn more" link color contrast:

image

image

@tonyanziano tonyanziano marked this pull request as ready for review September 4, 2019 19:46
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 65.586% when pulling 47c1db5 on toanzian/acc-dialog into 1b9a3ad on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants