Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE#1774] Update dirty on state when clicking on save button #1826

Merged
merged 1 commit into from
Sep 4, 2019
Merged

[ISSUE#1774] Update dirty on state when clicking on save button #1826

merged 1 commit into from
Sep 4, 2019

Conversation

denscollo
Copy link
Contributor

Solves #1774

Description

The save button wasn't updating the dirty variable, so it didn't change its state.

Changes made

  • Update dirty on state when clicking on save button

Testing

Issue1774-Solved

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 65.566% when pulling 0aca6f2 on fix-setting-editor-save-issue into 9e00b1a on master.

@tonyanziano tonyanziano merged commit 5022eb3 into master Sep 4, 2019
@tonyanziano tonyanziano deleted the fix-setting-editor-save-issue branch September 4, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denscollo @coveralls @tonyanziano @LCarbonellRod