Added error logging to OAuth signin link generation flow. #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
tonyanziano
force-pushed
the
toanzian/oauth-logging
branch
from
e03bd3b to
56cbd07
Compare
cwhitten
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1728
===
Before, if the Emulator failed to spin up an ngrok instance for the OAuth signin flow (due to a misconfigured ngrok path, or some other ngrok related error), it would swallow the error and fall back to generating an emulated OAuth token.
This change will now log any errors from that flow to the log panel, and tell the user that it is falling back to generating an emulated OAuth token.