Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup initial e2e tests with Spectron. #1696

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Setup initial e2e tests with Spectron. #1696

merged 2 commits into from
Jul 24, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Jul 23, 2019 •
edited
Loading

Addresses #1621

===

Added End to End (e2e) Tests using Spectron

  • Added two e2e tests and setup infrastructure
    • one test verifies that the app starts up with the correct title
    • the other test creates a bot via the create bot modal, and then verifies that the bot was written to disk
  • e2e tests can be ran from the root of the project using npm run test:e2e
  • added some id properties to HTML for easier WebDriver DOM traversing

e2e-test

@tonyanziano tonyanziano force-pushed the toanzian/e2e-spectron branch from 8429513 to 76f5b53 Compare July 23, 2019 21:15
@tonyanziano tonyanziano force-pushed the toanzian/e2e-spectron branch from 76f5b53 to a8ef2ec Compare July 24, 2019 20:36
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 62.932% when pulling a8ef2ec on toanzian/e2e-spectron into b345a01 on master.

@tonyanziano tonyanziano merged commit 35635ea into master Jul 24, 2019
@tonyanziano tonyanziano deleted the toanzian/e2e-spectron branch July 24, 2019 22:32
@tonyanziano tonyanziano mentioned this pull request Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyanziano @coveralls @a-b-r-o-w-n