Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1565 Bot State and Bot State Diff Pagination #1658

Merged
merged 15 commits into from
Jul 2, 2019
Merged

#1565 Bot State and Bot State Diff Pagination #1658

merged 15 commits into from
Jul 2, 2019

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Jun 25, 2019 •
edited
Loading

Fixes #1565

@justinwilaby justinwilaby changed the title [WIP] PR to Provide Bot State and Bot State Diff Pagination. #1565 Bot State and Bot State Diff Pagination Jun 28, 2019
@justinwilaby justinwilaby marked this pull request as ready for review June 28, 2019 21:11
tonyanziano
tonyanziano suggested changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions.

Going to pull it down and try it out, other than that it looks good! 👍

packages/app/main/src/extensions/inspector-preload.js
inspect: [],
theme: [],
},
handlers: new Proxy(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nifty 😮

packages/extensions/json/src/utils.ts Outdated Show resolved Hide resolved
packages/sdk/main/built/index.d.ts Outdated Show resolved Hide resolved
tonyanziano
tonyanziano approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit:

@cwhitten cwhitten merged commit 2247b47 into master Jul 2, 2019
@cwhitten cwhitten deleted the v-dai/stateDiffing branch July 2, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bot Inspector] Paged State-Diffing
4 participants
@justinwilaby @tonyanziano @cwhitten @ivanov-dan