Skip to content

Commit

Permalink
Added landmarks for improved keyboard navigation.
Browse files Browse the repository at this point in the history
  • Loading branch information
tonyanziano committed Sep 11, 2019
1 parent c7a8a91 commit 7ef388a
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1860](https://github.com/microsoft/BotFramework-Emulator/pull/1860)
- [1861](https://github.com/microsoft/BotFramework-Emulator/pull/1861)
- [1862](https://github.com/microsoft/BotFramework-Emulator/pull/1862)
- [1864](https://github.com/microsoft/BotFramework-Emulator/pull/1864)

- [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ interface LogPanelProps {
export default class LogPanel extends React.Component<LogPanelProps, {}> {
public render() {
return (
<div className={styles.logPanel}>
<div aria-label="log panel" className={styles.logPanel} role="region">
<Panel title="Log">
<PanelContent>
<Log document={this.props.document} />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ export class Inspector extends React.Component<InspectorProps, InspectorState> {
public render() {
if (this.state.inspector && this.state.inspectObj) {
return (
<div className={styles.detailPanel}>
<div aria-label="inspector panel" className={styles.detailPanel} role="region">
<Panel title={['inspector', this.state.title].filter(s => s && s.length).join(' - ')}>
{this.renderAccessoryButtons()}
<PanelContent>
Expand All @@ -214,7 +214,7 @@ export class Inspector extends React.Component<InspectorProps, InspectorState> {
} else {
return (
// No inspector was found.
<div className={styles.detailPanel}>
<div aria-label="inspector panel" className={styles.detailPanel} role="region">
<Panel title={`inspector`}>
<PanelContent>
<div className={styles.nothingInspected}>
Expand Down
4 changes: 2 additions & 2 deletions packages/app/client/src/ui/shell/main.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export class Main extends React.Component<MainProps, MainState> {
{!this.props.presentationModeEnabled && (
<NavBar selection={this.props.navBarSelection} explorerIsVisible={this.props.explorerIsVisible} />
)}
<div className={styles.workbench}>
<main className={styles.workbench}>
<Splitter
orientation={'vertical'}
primaryPaneIndex={0}
Expand All @@ -130,7 +130,7 @@ export class Main extends React.Component<MainProps, MainState> {
>
{workbenchChildren}
</Splitter>
</div>
</main>
<TabManagerContainer disabled={false} />
</div>
{!this.props.presentationModeEnabled && <StatusBar />}
Expand Down
8 changes: 4 additions & 4 deletions packages/app/client/src/ui/shell/mdi/mdi.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ import { TabBarContainer } from './tabBar';

export class MDIComponent extends React.Component<MDIProps> {
public render(): React.ReactNode {
const { presentationModeEnabled } = this.props;
const { presentationModeEnabled, owningEditor = '' } = this.props;
return (
<div className={styles.mdi}>
{!presentationModeEnabled && <TabBarContainer owningEditor={this.props.owningEditor} />}
<DocumentsContainer owningEditor={this.props.owningEditor} />
<div aria-label={`${owningEditor} editor`} className={styles.mdi} role="region">
{!presentationModeEnabled && <TabBarContainer owningEditor={owningEditor} />}
<DocumentsContainer owningEditor={owningEditor} />
</div>
);
}
Expand Down

0 comments on commit 7ef388a

Please sign in to comment.