Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update recognizer UI in form #7972

Merged
merged 1,865 commits into from
Jun 21, 2021
Merged

feat: update recognizer UI in form #7972

merged 1,865 commits into from
Jun 21, 2021

Conversation

VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Jun 1, 2021

Description

update recognizer UI in form.

Task Item

close #7935

Screenshots

image
image

pavolum and others added 30 commits April 15, 2021 12:09
…oser (#6936)

* Adding template sort order json

* Moving templates.json

* Cleaning up routing to no longer use old creation experience

* Removing unneeded fetchTemplate param

* Adding logic to attmpt to get template order and display name from git hub with shipped sort order as back up

* Adding ben and patrick as Composer dir code owners

* fixing unit test

* Making PR changes

* Fixing references with extra param

* Fix unused props lint error

* Remove unneeded fetch template call

* Fixing unit test

* Adding correct mocks for unit test

* Adding route to support older paths

* fixing unit test for new creation routing

Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Appsettings update

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* Remove unused event

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
… bubbles should pop out (#6973)

* adjust mechnaism used to determine if luis and qna bubbs should pop

* change name of variable

Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix hover lg template display format

* add dependency in package json

* fix test case failed

* modify test

Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* remodel Adapters section into new design

* better formatting

* fix table formatting

* update l10n strings

* Update AdapterSection.tsx

* Update AdapterSection.tsx

* Update AdapterSettings.test.tsx

* Update en-US.json

* Update en-US.json

* Update AdapterSettings.test.tsx

* address PR comments

Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Added hash to tab routing

* Fixing manage profile deep link

* Styling changes to remove double scroll bar in package manager

* Cleaning up style naming

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* display topics in left nav

* only show external link icon on hover

* sort system topics at end of list

* show tooltip when hovering on pva topic

* show system topic icon

* collapse topic list with Enter

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* update l10n files

* update l10n files
* include pva topics by default when pulling from pva

* allow autocomplete on select dialog

* limit height of callout

* update tooltip copy

Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
dont prefix output for CI

update github-actions formatter
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix header layout

* occupy screen width and fill card with background

* change card title style

* update card styles, color, font

* update styles

* update image setting

* update background , icon

* use NeutralColors.gray160

* define constant width height

Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
* fix: 6566 Update provision handoff copy

* fix: 6851

* Moved sign-in to config page

* Fixed broken QnA image svg
* removing unused commented code

* supporting client routing to defineConversation for PVA scenarios

* Ensuring runtimeType does not render as a creation dropdown for PVA scenarios

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* add skill select profile component

* manifest file cud  api

* add skill select page and publish logic

* folder rename

* add lu files writing logic

* add redirect to publishing page action

* change folder name

* add lu file parsing and intents filtering

* Support .lu and .qna for static files

* 'notification'

* manifest file name

* add skill add callers logic

* add manifest path to BotStructureFilesPatterns

* fix e2e

* notification

* add publish skill settings update

* pop auth

* add skill hostendpoint

* fix comments

* title change

* fix copy url wrong

* fix filtered lu files

* merge selectManifest & fetchManifest & description popup

* next bugfix

* bugfix

* merge main & popup err

* Fix endpoint not update issue

* Fix new adaptive runtime copy skill manifests to wwwroot folder

* skip step revert

* tooltip

* add back button & fix url color

* Update the logic of updating skill host endpoint

* callers set

* remove the physical file provider

* back button

* default select publish profie

* disabled generated & publish button when no profie

* url wrong

* default publish target

* callers error

* add create publish profile dialog

* comments

* callers

* lint

* lint fix

* lint ignore

* test case

* remove manifest folder from read patterns

* comments

* comments & conflict

* type

* bugfix

* Fix the logic of updating skill settings

* delete duplicate manifest url

* add profile popup logic

Co-authored-by: Qi Kang <kangqidev@gmail.com>
Co-authored-by: Long Jun <alanlong9278@126.com>
Co-authored-by: Long Alan <julong@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
* update add remote skill UI

* polish

* add trigger after skill created

* add action to on intent trigger after add remote skill

* import orchestrator after add remote skill

* add loading spinner

* fix bug

* add skill and alowCalled into appsettings

* fix skill identifier wrong in new action

* fix skill identifier

* remove allowedCaller when remove skill

* fix skill not added after add remote skill

* fix orchestractor modal not show

* remove trigger when remove skill, fix bugs

* polish UI

* add endpoint dropdown

* en-us

* filter duplicate msAppId in allowedCaller

* disable entity in lueditor

* polish

* fix some comments

* fix lint

* fix comments

* add prerelease

* fix test, fix endpoints bug, append intent to  multiLanguage lufile

* polish

* disable next if lueditor error

* fix lint

* fix multi language

* show warning msg if remote lufile get fail

* fix typecheck

* fix comments

* fix test

* fix comments

* fix test

* fix comments

* change sidebar back

* enus

Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: 6566 Update provision handoff copy

* fix: 6851

* Moved sign-in to config page

* Fixed broken QnA image svg

* fix issues with existing name stopping is new
* Make create from qna url modal blocking

* fix for bug in new tab view:
add botProjectData as dep to regenerate botStatusList

* Adding prevew tag to node tab in template selection view

* Fix error message for bot name

* fixing typo

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Genericizing OnChooseIntent

* Fix broken schema

* Allow more than 2 choices

* linter fixes

* trigger.ts not sending locale to worker

* Fix to normalize the names in lgUtil

* Remove all OnChooseIntent LG from common

* Rename parent template name to ChooseIntent

* Minor refactor

* fix linter issues

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* swap out details/summary for ul/li

* fix placement of items

* Update ExpandableNode.tsx

* fix layout issues and clicking behavior

* fix variables

* more fixes

* Update ExpandableNode.tsx

* Update ProjectTree.tsx

* Update ProjectTree.tsx

* remove stray comment

* Update expandableNode.test.tsx

* add new timeout to tests

* Update Breadcrumb.spec.ts

* post-merge fixes

* scope breadcrumb tests to inside breadcrumb

Co-authored-by: Andy Brown <asbrown002@gmail.com>
* migrate e2e test with create bot v2

* cache created bot from template

* update

* update

* update and merge

* update

Co-authored-by: Ben Brown <benbro@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix open abs, publish targets overwrite

* fix the get alias issue

Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
* fix: Remove tag entity menu from LU Toolbar

* remove en-US changes

* minor

* remove test
)

* Refactor LUIS, QNA and Speech to use a single base component

* fix height, sort order

* fix typing

* use shared colors

* refactor handoff instructions to share some text

* Update BotProjectsSettingsTabView.tsx

* refactor qna maker provisioning into a background process

* fix linter quible:w

* remove dep

* rename setVisible to onToggleVisibility

* Use shared color

* add conditional around missing hostname

* add conditional around missing hostname

* remove duplicate import

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
* Make firendly link and add blank targer for broken azure link

* Fix scrollilng in publish modal

* Fixed comment box in publish confirm modal

* configure resource ui fix #6886

* import existing resources fit and finish #6889

* #7132: standardizing qna plural/singular resource strings

* #7133: disabling Luis and Qna exit modal functionality when resources are being created

* #7126: remove semi colen

* Updating localized text

* Fixing inline conditionals

* Updating unit test

* Initial changes from UI meeting

* Removing unused imports

* Adding back changes reverted during merge
* catch dotnet error

* Handle error for missing dotnet 3.1 during creation

* remove unnecessary wrapper funct

* update to syntax of component, small cleanup items from PR

* remove old NodeModal (replaced by InstallDepMOdal)

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
lei9444 and others added 7 commits June 10, 2021 18:54
* fix: incorrect expression validation for dialog

* fix conner case

* update the comments

* add some comment

* fix lint

Co-authored-by: Dong Lei <donglei@microsoft.com>
* Add T&C accept for teams

* remove mystery dep

* remove console

* Update formatMessage to use formatMessage.rich for complex content

Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* -Adding getstarted teach bubble to app state
-creating a dispatcher for it

* setting state value to show teaching bubble as opposed to hash routing

* adding onclick state changing to manage state for teaching button dismisal

* Refining naming for distinct teaching bubbles
@VanyLaw
Copy link
Contributor Author

VanyLaw commented Jun 11, 2021

@VanyLaw , Can you adjust the UX to make sure we follow Vivek's design, for example:

  • remove the "recognizer" in titles.
  • add "." at the end of the sentence.
  • the size of the modal.

image

updated.
image

@luhan2017
Copy link
Contributor

@hatpick, could you help take another look at this PR.

@cypress
Copy link

cypress bot commented Jun 21, 2021



Test summary

16 0 1 0Flakiness 0


Run details

Project Composer
Status Passed
Commit bca78fe
Started Jun 21, 2021 7:15 AM
Ended Jun 21, 2021 7:23 AM
Duration 07:27 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@luhan2017 luhan2017 merged commit e545ab8 into main Jun 21, 2021
@luhan2017 luhan2017 deleted the wenyluo/newUI branch June 21, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New UX to switch recognizer type