Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 6566 Update provision handoff copy #6911

Merged
merged 5 commits into from
Apr 13, 2021
Merged

fix: 6566 Update provision handoff copy #6911

merged 5 commits into from
Apr 13, 2021

Conversation

GeoffCoxMSFT
Copy link
Member

Description

Adjusted ProvisionHandoff to match figma
Updated provisioning instructions to match figma

Task Item

fixes #6566

Screenshots

image
image

@hatpick
Copy link
Contributor

hatpick commented Apr 13, 2021

@JaskeeratBedi-cmk can we avoid using generic exclamation phrases such as "Okay" in the UX and instead use a more specific action verb that semantically matches the purpose of the button?

@JaskeeratBedi-cmk
Copy link

@hatpick in general we try to have make the CTA verb first. However this modal is really an exception.
In this modal the user must

  • copy the instruction
  • paste it outside of the app ( to share with the azure admin)
  • come back to Composer and dismiss this modal

While designing, we explored CTAs like 'Copy', but then user still has to dismiss after they have completed the action..
So ended up with either done or ok. And it seems like Ok is the standard we use when user needs to acknowledge.

@hatpick
Copy link
Contributor

hatpick commented Apr 13, 2021

@hatpick in general we try to have make the CTA verb first. However this modal is really an exception.
In this modal the user must

  • copy the instruction
  • paste it outside of the app ( to share with the azure admin)
  • come back to Composer and dismiss this modal

While designing, we explored CTAs like 'Copy', but then user still has to dismiss after they have completed the action..
So ended up with either done or ok. And it seems like Ok is the standard we use when user needs to acknowledge.

In this particular Dialog, it seems like "Okay" basically closes the dialog, unless it records some data indicating that user acknowledges reading and understanding the information above, I think a simple "Close" will do. What do you think?

@coveralls
Copy link

coveralls commented Apr 13, 2021

Coverage Status

Coverage remained the same at 51.108% when pulling e75d48f on gcox/mainwork into 991edc8 on main.

@GeoffCoxMSFT GeoffCoxMSFT merged commit 3766302 into main Apr 13, 2021
@GeoffCoxMSFT GeoffCoxMSFT deleted the gcox/mainwork branch April 13, 2021 21:37
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Copy for Share Resource Request Instructions
5 participants