-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bot can't start or publish by cleaning unused code #6816
Merged
+0
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydc2014
requested review from
benbrown,
GeoffCoxMSFT,
hatpick and
tonyanziano
as code owners
April 9, 2021 05:48
boydc2014
changed the title
fix: check runtime.setSkillManifest before calling
fix: clean unused code
Apr 9, 2021
Looks like the setSkillManifest is not used anymore, @benbrown can you help confirm? |
boydc2014
changed the title
fix: clean unused code
fix: check setSkillManifest and clean unused code
Apr 9, 2021
boydc2014
changed the title
fix: check setSkillManifest and clean unused code
fix: clean unused code
Apr 9, 2021
boydc2014
changed the title
fix: clean unused code
fix: bot can't start or publish by cleaning unused code
Apr 9, 2021
luhan2017
approved these changes
Apr 9, 2021
alanlong9278
added a commit
that referenced
this pull request
Apr 9, 2021
* main: fix: bot can't start or publish by cleaning unused code (#6816)
This was referenced Apr 9, 2021
Closed
srinaath
pushed a commit
that referenced
this pull request
Apr 21, 2021
This reverts commit d892234. Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # extensions/localPublish/src/index.ts
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* main: fix: bot can't start or publish by cleaning unused code (microsoft#6816)
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* qika/skill: tooltip fix: bot can't start or publish by cleaning unused code (microsoft#6816) fix: make composer support https proxy (microsoft#6766)
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* main: fix: bot can't start or publish by cleaning unused code (#6816)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Guard setSkillManifest * remove unused code * Still keep it under guard * remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor