Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bot can't start or publish by cleaning unused code #6816

Merged
merged 6 commits into from
Apr 9, 2021

Conversation

boydc2014
Copy link
Contributor

@boydc2014 boydc2014 commented Apr 9, 2021

image
image
#minor

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@boydc2014 boydc2014 changed the title fix: check runtime.setSkillManifest before calling fix: clean unused code Apr 9, 2021
@coveralls
Copy link

coveralls commented Apr 9, 2021

Coverage Status

Coverage remained the same at 51.141% when pulling 67e30c7 on donglei/guard-skill-manifest into 683520a on main.

@boydc2014
Copy link
Contributor Author

Looks like the setSkillManifest is not used anymore, @benbrown can you help confirm?

@boydc2014 boydc2014 changed the title fix: clean unused code fix: check setSkillManifest and clean unused code Apr 9, 2021
@boydc2014 boydc2014 changed the title fix: check setSkillManifest and clean unused code fix: clean unused code Apr 9, 2021
@boydc2014 boydc2014 changed the title fix: clean unused code fix: bot can't start or publish by cleaning unused code Apr 9, 2021
@boydc2014 boydc2014 merged commit d892234 into main Apr 9, 2021
@boydc2014 boydc2014 deleted the donglei/guard-skill-manifest branch April 9, 2021 06:28
alanlong9278 added a commit that referenced this pull request Apr 9, 2021
* main:
  fix: bot can't start or publish by cleaning unused code (#6816)
alanlong9278 added a commit that referenced this pull request Apr 9, 2021
* qika/skill:
  tooltip
  fix: bot can't start or publish by cleaning unused code (#6816)
  fix: make composer support https proxy (#6766)
srinaath pushed a commit that referenced this pull request Apr 21, 2021
This reverts commit d892234.

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

# Conflicts:
#	extensions/localPublish/src/index.ts
@cwhitten cwhitten mentioned this pull request May 20, 2021
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* main:
  fix: bot can't start or publish by cleaning unused code (microsoft#6816)
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* qika/skill:
  tooltip
  fix: bot can't start or publish by cleaning unused code (microsoft#6816)
  fix: make composer support https proxy (microsoft#6766)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* main:
  fix: bot can't start or publish by cleaning unused code (#6816)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* qika/skill:
  tooltip
  fix: bot can't start or publish by cleaning unused code (#6816)
  fix: make composer support https proxy (#6766)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Guard setSkillManifest

* remove unused code

* Still keep it under guard

* remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants