fix: Update AppSettings obj to match new format set by new runtime #6774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolum
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
…/BotFramework-Composer into pavolum/appsettingsFix
…/BotFramework-Composer into pavolum/appsettingsFix
…/BotFramework-Composer into pavolum/appsettingsFix
Thats a good question. My assumption is that the migration flow will ensure that the expected appsettings for all bots that hit this point in the flow are normalized to the new version. I will double check on this. @benbrown is my assumption correct? |
|
Yes this is handled in the migration: |
a-b-r-o-w-n
previously approved these changes
Apr 13, 2021
a-b-r-o-w-n
previously approved these changes
Apr 13, 2021
a-b-r-o-w-n
approved these changes
Apr 14, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…icrosoft#6774) * Updating AppSettings type obj to reflect new runtime appSettings structure * Updating default appSettings obj per type update * Updating allowedCallers Ui component to interface with new location of AllowedCallers * Adding allowedCallers to tab settings UI view * Adding allowedCallers null check * Moving AdapterRecord type to types workspace * Updating imports for adapter record * Fixing runtimeSettings type * Fix linting errors * Fixing types definition * Fixing typing...again * Fixing imports * Cleaning up typing of appsettings Obj * Fixing type bug introduced in merging with latest main * Fixing errors from merge * removing unused import Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New runtime anticipates AllowedCallers within appsettings JSON to be in runtimeSettings as opposed to within old runtimes skillsConfiguration obj.
This PR:
Task Item
fixes #6647