Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Lu improvements, larger Lg editor, activity action node content #6539

Merged
merged 11 commits into from
Mar 25, 2021
Merged

feat: Lu improvements, larger Lg editor, activity action node content #6539

merged 11 commits into from
Mar 25, 2021

Conversation

hatpick
Copy link
Contributor

@hatpick hatpick commented Mar 24, 2021 •
edited
Loading

Description

  • Improvement to the Lu editor by adding a toolbar for defining/inserting ML/prebuilt entities
  • Adds floating labeling menu for ML entities to Lu editor
  • Adds larger Lg editor for when in code editing mode or attachment editing in response editor.
  • Custom action node content for Lg templates with structured response.

Task Item

closes #6503
closes #6502
closes #6413

Screenshots

Action node custom text for structured responses

Action node

Lu editor improvements

Lu toolbar

Floating labeling menu

Floating labeling menu

Lu toolbar - insert entity

insert entity

Lu toolbar - define entity

Define entity

Lg response editor - attachment larger editor

Attachment larger editor
RE - Larger editor

Lg code editor - larger editor

Lg code editor - larger editor
CE - Larger editor

@coveralls
Copy link

coveralls commented Mar 24, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 52.322% when pulling 04aa0f3 on sorgh/lu-editor into 60be261 on main.

GeoffCoxMSFT
GeoffCoxMSFT previously approved these changes Mar 25, 2021
View reviewed changes
@hatpick hatpick merged commit 231a8b9 into main Mar 25, 2021
@hatpick hatpick deleted the sorgh/lu-editor branch March 25, 2021 18:13
@cwhitten cwhitten mentioned this pull request May 20, 2021
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@hatpick @sorgh
feat: Lu improvements, larger Lg editor, activity action node content (…
ab64375 
…microsoft#6539)

* Lu improvements, larger Lg editor, activity action node content

* strings

* fix test

* added tests

* more test

* PR comments

Co-authored-by: Soroush <sorgh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffCoxMSFT GeoffCoxMSFT GeoffCoxMSFT approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@hatpick @coveralls @GeoffCoxMSFT @sorgh