fix: refactor workers into their own package #6382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exclude server-workers deps from yarn workspace
benbrown
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
|
@lei9444 can you help take a look at this one, and verify if there is impact to the way other workers are used or packed? |
hatpick
reviewed
Mar 12, 2021
| @@ -8,23 +8,22 @@ import yeoman from 'yeoman-environment'; | |||
| import TerminalAdapter from 'yeoman-environment/lib/adapter'; | |||
There was a problem hiding this comment.
remove commented code
a bunch of awaits down below are not necessary, linter shows them.
cwhitten
requested changes
Mar 12, 2021
| "dependencies": { | ||
| "yeoman-environment": "^2.10.3", | ||
| "format-message": "^6.2.3", | ||
| "@microsoft/bf-dialog": "4.11.0-dev.20201025.69cf2b9" |
Composer/packages/server-workers/src/templateInstallation.worker.ts
Outdated
Show resolved
Hide resolved
|
@benbrown and I discussed offline, I am going to finish up this work today. |
the @types package is outdated, so we'll want to update that when a new version is published
cwhitten
approved these changes
Mar 13, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* refactor workers into their own package * unpack the new server-workers module exclude server-workers deps from yarn workspace * adjustments to workspace settings * fix typo in path * expose ServerWorker class for workers * update yeoman-environment the @types package is outdated, so we'll want to update that when a new version is published * mock server worker in test Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactors the server workers into their own package.
cuts direct dependencies on server internals.
this allows the workers to be unpacked in the electron repo and used.
Task Item
fixes #6372