fix: add cache for orchestrator build to reduce the re-build time #6373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
taicchoumsft
previously approved these changes
Mar 11, 2021
taicchoumsft
approved these changes
Mar 11, 2021
cwhitten
approved these changes
Mar 11, 2021
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…crosoft#6373) * fix: add cache for orchestrator build to reduce the re-build time * fix unit tests Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue
composer will do orchestrator build every time. some big bot may take 15min. It is a long time to wait even the lu files don't update.
fix
Add the cache of LabelResolvers for orchestrator build. the build worker will re-use the resolvers and reduce the re-training time.
In my local test, the first time will use 15min and the second only use 800ms.
Task Item
#minor
Screenshots