Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Webchat 4.12 upgrade #6075

Merged
merged 9 commits into from
Mar 2, 2021
Merged

chore: Webchat 4.12 upgrade #6075

merged 9 commits into from
Mar 2, 2021

Conversation

srinaath
Copy link
Contributor

@srinaath srinaath commented Mar 2, 2021 •
edited
Loading

Description

This PR

  1. Updates Webchat version to 4.12
  2. Removes yarn policy set currently at 1.19.1
  3. Removes the hard requirement of Node 14 for running Composer from source. Sets it back to Node 12 before adding the webchat dependancy

UI Fix
 

Screen Shot 2021-03-01 at 4 18 42 PM

@chrimc62 @sgellock

Task Item

Fixes #6040

Srinaath Ravichandran and others added 8 commits March 1, 2021 15:06
Webchat test cases
87c2d0a 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@srinaath
Merge branch 'main' into fix/webchat-skill-context
97c9c67
Add aria label
b643fdd 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Merge branch 'fix/webchat-skill-context' of https://github.com/micros…
56f3044 
…oft/BotFramework-Composer into fix/webchat-skill-context
Updated aria -label
6f56e60 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Webchat version updates
5641c74 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Remove yarnrc
018772d 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Removed yarn 19 ref
1e82436 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@srinaath srinaath added the 1.4 label Mar 2, 2021
@srinaath srinaath added this to the R12 milestone Mar 2, 2021
@srinaath srinaath changed the title chore: Webchat 4.12 chore: Webchat 4.12 upgrade Mar 2, 2021
@coveralls
Copy link

coveralls commented Mar 2, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 53.756% when pulling 8809563 on chore/webchat-version-update into 0728122 on main.

@srinaath srinaath merged commit 9f5fb9b into main Mar 2, 2021
@srinaath srinaath deleted the chore/webchat-version-update branch March 2, 2021 02:17
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@srinaath
chore: Webchat 4.12 upgrade (microsoft#6075)
7780c89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@cwhitten cwhitten

Labels
1.4 Webchat Integration
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

Upgrade Composer to use Webchat 4.12
3 participants
@srinaath @coveralls @cwhitten