chore: remove $kind restriction on Flow Editor layouter #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
yeze322
changed the title
yeze322
changed the title
|
@cwhitten @EricDahlvang please review |
This was referenced Feb 26, 2021
Closed
|
a lot of adaptive-flow UT seems to be failing |
|
@boydc2014 Oops, it's the circular reference problem |
boydc2014
approved these changes
Mar 1, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* remove $kind restriction on branching transformers * defense non-obejct input in transformers * nowrap by default for branching nodes * avoid circular reference Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #5395
Summary
Be able to reuse builtin branching widgets in custom Actions. (
IfConditionWidget|SwitchConditionWidget|ForeachWidget)Changes
IfConditionWidget|SwitchConditionWidget|ForeachWidgetto reuse them.nowrapflag to all above widgets in case uischema author forgets to add it. (without this flag, the layout will be messed up)Explaination:
Now that we already supported uischema driven Action customization, the Flow Editor's layouter shouldn't restrict the input $kind anymore. By removing the $kind checking logic, those branching widgets are opened to external $kinds.
External Action $kind can then declare the
widgetfield as one ofIfConditionWidget|SwitchConditionWidget|ForeachWidgetin uischema flow part.Follow-up:
@zxyanliu let's document it!
Task Item
Screenshots
IfConditonWidget