fix: generate friendlier project names from new long package names. #5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
benbrown
changed the title
2 tasks
…BotFramework-Composer into benbrown/createstatus
cwhitten
reviewed
Feb 26, 2021
Composer/packages/client/src/components/CreationFlow/v2/DefineConversation.tsx
Outdated
Show resolved
Hide resolved
cwhitten
approved these changes
Feb 26, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…icrosoft#5983) * Fix microsoft#5948: generate friendlier project names * fix microsoft#5987 update copy in create flow * fix test * remove console log Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this applies a similar heuristic used by the server to generate pretty names for the project name based on the package name.
@microsoft/generator-microsoft-bot-conversational-core becomes "conversational_core"
this should preserve the current naming behavior, but apply it to the new flows.
Task Item
fixes #5948
fixes #5987
Screenshots