fix: support relative path to runtime #5950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
|
@alanlong9278 can you check this out and double check it for me? I think I've addressed all the spots where the runtime path is used. |
a-b-r-o-w-n
reviewed
Feb 25, 2021
| @@ -352,7 +351,7 @@ export default async (composer: IExtensionRegistration): Promise<void> => { | |||
|
|
|||
| let runtimePath = currentProject.settings?.runtime?.path; | |||
| if (runtimePath && !path.isAbsolute(runtimePath)) { | |||
| runtimePath = path.resolve(currentProject.dir, runtimePath); | |||
| runtimePath = path.resolve(currentProject.dir, 'settings', runtimePath); | |||
| } | |||
There was a problem hiding this comment.
I'm a little worried about the amount of duplicated code. Can we add a method to the project that centralizes this?
There was a problem hiding this comment.
@a-b-r-o-w-n I addressed this. Want to give it another look?
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Properly support relative path to runtime * refactor path computation into a single method on the botproject model Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task Item
Fixes #5786
Replaces #5838