feature: Add support for MSA authentication #5909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick and
srinaath
as code owners
…oser into toanzian/msa
…oser into toanzian/msa
|
@zidaneymar @VanyLaw can you help take a look at this one? |
boydc2014
approved these changes
Mar 1, 2021
3 tasks
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Implemented server-side endpoints for ARM auth * Removed old debug code * Exposed getTenants and getARMTokenForTenant to extensions * Added CSRF protection to ARM routes * Added extra logging to ARM flow * Fixed tests * Added try-catch blocks and better logging * Added tests Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for MSA / personal Microsoft account authentication with the OneAuth library. It also enables Composer and any Composer extensions to log the user in to retrieve an ARM token.
Adds new APIs for getting a list of Azure tenants for a user, and getting an ARM token for the selected tenant.
Task Item
#minor
Helps fix issue #5393, but work will need to be done inside the publishing extensions to leverage this feature.