Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add policies for yarn to fix the yarn version #5854

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Feb 20, 2021

Description

issue
run yarn add to client will throw error
ca9ee1d8-e2b5-4cd7-8856-e9792323f6c8

fix
run yarn policies set-version 1.19.1 to make the yarn version is 1.19.1 when run composer
image

Task Item

#minor

Screenshots

@lei9444
Copy link
Contributor Author

lei9444 commented Feb 20, 2021

This PR may cause build failed, close it first

@lei9444 lei9444 closed this Feb 20, 2021
@lei9444 lei9444 reopened this Feb 22, 2021
@lei9444 lei9444 marked this pull request as draft February 22, 2021 11:03
@coveralls
Copy link

coveralls commented Feb 22, 2021

Coverage Status

Coverage remained the same at 53.906% when pulling bde1a25 on lei9444:yarntest into 267ee0f on microsoft:main.

@lei9444
Copy link
Contributor Author

lei9444 commented Feb 22, 2021

close this one, This PR can't solve the build error

@lei9444 lei9444 closed this Feb 22, 2021
@srinaath srinaath reopened this Feb 22, 2021
@lei9444 lei9444 closed this Feb 23, 2021
@lei9444 lei9444 reopened this Feb 23, 2021
@boydc2014 boydc2014 self-assigned this Feb 24, 2021
@boydc2014 boydc2014 added the 1.4 label Feb 24, 2021
@lei9444 lei9444 changed the title fix: update the yarn.lock to fix the yarn add error fix: add yarn version to engines to fix the yarn add error Feb 24, 2021
@lei9444 lei9444 changed the title fix: add yarn version to engines to fix the yarn add error fix: add policies for yarn to fix the yarn version Feb 24, 2021
@lei9444 lei9444 marked this pull request as ready for review February 24, 2021 04:45
@srinaath srinaath added this to the R12 milestone Feb 24, 2021
@srinaath srinaath merged commit ab5f35b into microsoft:main Feb 25, 2021
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants