Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable LUIS directVersionPublish #5749

Merged
merged 14 commits into from
Mar 8, 2021
Merged

fix: disable LUIS directVersionPublish #5749

merged 14 commits into from
Mar 8, 2021

Conversation

liweitian
Copy link
Contributor

@liweitian liweitian commented Feb 10, 2021 •
edited by boydc2014
Loading

Description

Disable directVersionPublish, as it's causing compatible issue to previous users

Changes

  • set directVersionPublish = false when publishing
  • remove version property in publishing result(luis.settings.json) to avoid runtime picking direct version publishing api

Task Item

#minor

Screenshots

publish

@boydc2014 boydc2014 changed the title fix: remove version property in luisSettings fix: disable LUIS directVersionPublish Feb 10, 2021
@luhan2017 luhan2017 mentioned this pull request Feb 18, 2021
Closed
6 tasks
@boydc2014
Copy link
Contributor

@liweitian please fix the UT

@coveralls
Copy link

coveralls commented Feb 19, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 53.385% when pulling 5c8a97f on publishBug into 215af1a on main.

@liweitian
Copy link
Contributor Author

liweitian commented Feb 19, 2021 •
edited
Loading

@liweitian please fix the UT

@boydc2014 fixed.

@boydc2014 boydc2014 added the 1.4 label Feb 24, 2021
@boydc2014 boydc2014 assigned luhan2017 and unassigned boydc2014 Feb 24, 2021
@boydc2014
Copy link
Contributor

@luhan2017 can you help Tom signed off on this one

@boydc2014 boydc2014 merged commit 6bfa120 into main Mar 8, 2021
@boydc2014 boydc2014 deleted the publishBug branch March 8, 2021 12:31
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@liweitian @boydc2014 @luhan2017
fix: disable LUIS directVersionPublish (microsoft#5749)
0b0fa2a 
* remove version property in luisSettings

* handle comments

* fix UT

* set directVersionPublish true for new bots

* fix UT

Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@boydc2014 boydc2014

@luhan2017 luhan2017

Labels
1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liweitian @boydc2014 @coveralls @luhan2017