Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply new deisgn on project tree to solve Critical create actions inaccessible issue on Project Tree #5722

Merged
merged 14 commits into from
Feb 10, 2021

Conversation

liweitian
Copy link
Contributor

@liweitian liweitian commented Feb 8, 2021

Description

apply new design on project tree without the addTrigger and addDialog icons
https://www.figma.com/file/deFhMPBnRWxTYiYDYqYxrc/Composer-Vivek?node-id=10809%3A0

and

solve a bug on resizing the project window.
It does not re-render when resizing because the "leftSplitWidth" is not passed into the an useCallback function as a dependency. So some very long name dialog is still hidden after expanding the window.

Task Item

Closes #5681

Screenshots

split

@coveralls
Copy link

coveralls commented Feb 8, 2021

Coverage Status

Coverage increased (+0.05%) to 55.098% when pulling 6d71ca5 on bug5681-2 into 8cde5d7 on main.

@hatpick
Copy link
Contributor

hatpick commented Feb 8, 2021

As for the two svg Icons you are creating, I highly recommend looking into this:

import { createSvgIcon } from '@fluentui/react-icons';

from fabric.

Considering you have the svg code for the icons you can do this:

const myIconSvg = ` the svg code `; // svg code for the icon in string format
const MyIcon = createSvgIcon({ svg: () => myIconSvg, displayName: 'MyIcon' }); // Icon component showing the svg icon

now you can use MyIcon like <MyIcon style={ any style of type React.CSSProperties} />

@liweitian
Copy link
Contributor Author

As for the two svg Icons you are creating, I highly recommend looking into this:

import { createSvgIcon } from '@fluentui/react-icons';

from fabric.

Considering you have the svg code for the icons you can do this:

const myIconSvg = ` the svg code `; // svg code for the icon in string format
const MyIcon = createSvgIcon({ svg: () => myIconSvg, displayName: 'MyIcon' }); // Icon component showing the svg icon

now you can use MyIcon like <MyIcon style={ any style of type React.CSSProperties} />

all comments handled

hatpick
hatpick previously approved these changes Feb 9, 2021
boydc2014
boydc2014 previously approved these changes Feb 9, 2021
@boydc2014 boydc2014 merged commit 50b8304 into main Feb 10, 2021
@boydc2014 boydc2014 deleted the bug5681-2 branch February 10, 2021 08:05
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…ns inaccessible issue on Project Tree (microsoft#5722)

* save for tmp use

* save tmp code

* save for tmp use

* add two more buttons

* update calculation for treeitem text maxwidth

* show parent icons if a link selected

* fix resize bug

* fix resize bug

* remove unused file

* handle comments

* fix truncated treeitem width bug

* remove addTrigger and addDialog Icons

Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav overlaps with three dot menus - Critical create actions inaccessible
5 participants