-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply new deisgn on project tree to solve Critical create actions inaccessible issue on Project Tree #5722
Conversation
Composer/packages/client/src/components/ProjectTree/AddDialogIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/AddDialogIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/AddDialogIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/AddTriggerIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/AddTriggerIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/AddTriggerIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/ProjectTree.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/treeItem.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/treeItem.tsx
Outdated
Show resolved
Hide resolved
As for the two svg Icons you are creating, I highly recommend looking into this:
from fabric. Considering you have the svg code for the icons you can do this:
now you can use MyIcon like <MyIcon style={ any style of type React.CSSProperties} /> |
all comments handled |
…ns inaccessible issue on Project Tree (microsoft#5722) * save for tmp use * save tmp code * save for tmp use * add two more buttons * update calculation for treeitem text maxwidth * show parent icons if a link selected * fix resize bug * fix resize bug * remove unused file * handle comments * fix truncated treeitem width bug * remove addTrigger and addDialog Icons Co-authored-by: Dong Lei <donglei@microsoft.com>
Description
apply new design on project tree without the addTrigger and addDialog icons
https://www.figma.com/file/deFhMPBnRWxTYiYDYqYxrc/Composer-Vivek?node-id=10809%3A0
and
solve a bug on resizing the project window.
It does not re-render when resizing because the "leftSplitWidth" is not passed into the an useCallback function as a dependency. So some very long name dialog is still hidden after expanding the window.
Task Item
Closes #5681
Screenshots