fix: consume some env variables from bash instead of JS #5696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick and
srinaath
as code owners
tonyanziano
previously approved these changes
Feb 4, 2021
tonyanziano
approved these changes
Feb 4, 2021
cwhitten
pushed a commit
that referenced
this pull request
Feb 10, 2021
* consume some env variables from bash instead of JS * update DEV_CERT_ID to be consumed in bash
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* consume some env variables from bash instead of JS * update DEV_CERT_ID to be consumed in bash
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* consume some env variables from bash instead of JS * update DEV_CERT_ID to be consumed in bash
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* consume some env variables from bash instead of JS * update DEV_CERT_ID to be consumed in bash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not interpolate env variables when executing bash scripts. This had unintended consequences when values contained un-escaped characters. It is also safer to do so by not leaking secrets in the bash history.
Task Item
#minor