fix: yarn start:dev throw error #5609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
|
Cool, It can work now. |
srinaath
approved these changes
Jan 27, 2021
|
@srinaath can we have this merged asap? it keeps crashing on me. |
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix: yarn start:dev throw error * update immer to 8.0.1 Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Soroush <hatpick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The version of react-dev-utils was upgraded to 11.0.1 in #5600 to fix immer security error. But yarn start:dev will throw error at this version.
I not sure why this will happen, but the version of immer(7.0.9) it used still has security issue. so I revert some of the code first to ensure the yarn start:dev is ok.
Updates
Add immer to resolutions to fix the version
Task Item
refs #5600
Screenshots