Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Several PVA integration improvements / bug fixes #4776

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

tonyanziano
Copy link
Contributor

Description

  • fixes flakiness in publishing to PVA due to a race condition when writing the .zip to the outgoing request
  • adds support to the publish status page for clickable actions or links (ex. "Test in PVA" after publishing)
  • should fix inconsistencies with invalid dates appearing in the publish status list
  • fixes wrong path in the success notification after an import (was pointing to bot location instead of backup location)
  • expands the width of the publish job log

Task Item

fixes #4385

@coveralls
Copy link

coveralls commented Nov 12, 2020

Coverage Status

Coverage decreased (-0.005%) to 54.732% when pulling 50c7eb5 on toanzian/fix/pva-qol into 2b23ff6 on main.

@cwhitten cwhitten merged commit e4c4f36 into main Nov 12, 2020
@cwhitten cwhitten deleted the toanzian/fix/pva-qol branch November 12, 2020 01:13
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Nov 16, 2020
* settingsPage: (22 commits)
  Refactoring function calls
  fix: remove special case for single-bot view in tree (microsoft#4803)
  fix bug
  fix UT
  code refine
  Removed other languages for now. (microsoft#4789)
  Made the default width for the property editor wider (microsoft#4788)
  pass csrf token to plugin hosts (microsoft#4787)
  Updated disability styles
  chore: rebase main onto bot-projects feature branch (microsoft#4780)
  fix: zip file can not be deleted (microsoft#4760)
  Remove enforce auto end dialog for skill bots (microsoft#4440)
  Several PVA integration improvements / bug fixes (microsoft#4776)
  Updated strings from building (microsoft#4762)
  feat: Implement pull from publish target (microsoft#4768)
  fix: Allowed 404 to fall through axios during import flow (microsoft#4770)
  increase unit tests timeout to 30 min (microsoft#4764)
  feat: Allow importing bot content from an external source (microsoft#4751)
  Localized resource files from OneLocBuild (microsoft#4730)
  force node extensions to only require commonjs (microsoft#4755)
  ...
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull from publish target (PVA scenario)
3 participants