Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing the import qna file when generating the recognizer dialog #4473

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Oct 22, 2020

Description

use the parse result empty field to check the empty file. and the empty file can't be added to the *.lu.qna.dialog file.
The import Sections are filtered out. So use qnaSections' length can't regarded the file is empty.

Task Item

#minor

Screenshots

@coveralls
Copy link

coveralls commented Oct 22, 2020

Coverage Status

Coverage remained the same at 55.227% when pulling fd51237 on lei9444:fixqnaempty into 06bb324 on microsoft:main.

@boydc2014 boydc2014 merged commit 819481b into microsoft:main Oct 23, 2020
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
@lei9444 lei9444 deleted the fixqnaempty branch February 1, 2021 02:08
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants