Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates regular expressions formatting and naming convention #4398

Merged

Conversation

stevkan
Copy link
Contributor

@stevkan stevkan commented Oct 15, 2020

Description

The naming convention between the different recognizer types is inconsistent when the user clicks on the associated dropdown. These changes are implemented to bring consistency across the various JSON, .spec.ts, and .dialog files.

Task Item

Replaces #4297
Closes #4060

Screenshots

e2e test:

image

@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.994% when pulling 1e6296d on stevkan:stevkan/update-recognizer-type-names into 27345fe on microsoft:main.

@zxyanliu
Copy link
Contributor

@a-b-r-o-w-n
Per your request, I reviewed this PR and it looks good to me.
Please take a second look before merging. Thanks!

@a-b-r-o-w-n a-b-r-o-w-n merged commit 64b4070 into microsoft:main Oct 16, 2020
@cwhitten
Copy link
Member

thank you @stevkan !

@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Recognizer type's naming rule needs to be consistent
5 participants