feat: Added jsonSchema and trigger content #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
hatpick
reviewed
Oct 12, 2020
Composer/packages/lib/indexers/__tests__/jsonSchemafileIndexer.test.ts
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
changed the title
hatpick
reviewed
Oct 13, 2020
…icrosoft/BotFramework-Composer into gcox/support-json-schema-files
hatpick
reviewed
Oct 15, 2020
hatpick
approved these changes
Oct 15, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added jsonSchema and trigger content * Fix for filtering skill manifests * PR fixes * Fixing baseName and test issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to group triggers by property name, the JSON schema files referenced by dialog must be returned as assets to the bot from the server. As well the trigger content needs to be included to inspect conditions and properties.
This first PR get the data to the client.
Task Item
#minor
#4150
Screenshots
N/A