Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor UX fixes for installing extensions #4308

Merged
merged 10 commits into from
Oct 1, 2020
Merged

fix: minor UX fixes for installing extensions #4308

merged 10 commits into from
Oct 1, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

Task Item

#minor

tonyanziano
tonyanziano previously approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 55.589% when pulling 76ac9d7 on abrown/extensions/install-local into f41b7e0 on main.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 7f0b37d into main Oct 1, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the abrown/extensions/install-local branch October 1, 2020 20:08
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@a-b-r-o-w-n
fix: minor UX fixes for installing extensions (microsoft#4308)
6e543ea 
* use plugin id for page links

* add api to install local extension

* disable add button when no extension selected

* fix settings page redirect issue

* normalize search query for extensions

* revert api to install local extension

* fix shimmer row when no extensions installed

* add test for unsuccessul install

* fix type error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

Assignees

@tonyanziano tonyanziano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-b-r-o-w-n @coveralls @tonyanziano