Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: language err for build luis in azure deploy #4155

Merged
merged 5 commits into from
Sep 18, 2020
Merged

fix: language err for build luis in azure deploy #4155

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0857e2
language err for build luis
alanlong9278 Sep 16, 2020
2c30c18
refactor
alanlong9278 Sep 17, 2020
b8ceef1
Merge branch 'main' into julong/language-err-for-publish
alanlong9278 Sep 18, 2020
1ff2eb6
Merge branch 'main' into julong/language-err-for-publish
cwhitten Sep 18, 2020
66d1371
Merge branch 'main' into julong/language-err-for-publish
a-b-r-o-w-n Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Composer/plugins/azurePublish/src/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@ export class BotProjectDeploy {

// STEP 2: UPDATE LUIS
// Do the LUIS build if LUIS settings are present
if (!language) {
language = 'en-us';
let luisLanguage = language || settings.luis.defaultLanguage;
alanlong9278 marked this conversation as resolved.
Show resolved Hide resolved
if (!luisLanguage) {
luisLanguage = 'en-us';
}
const publisher = new LuisAndQnaPublish({ logger: this.logger, projPath: this.projPath });

Expand All @@ -66,7 +67,7 @@ export class BotProjectDeploy {
name,
environment,
this.accessToken,
language,
luisLanguage,
settings.luis,
settings.qna,
luisResource
Expand Down