Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update title of "new bot" dialog #4063

Merged
merged 6 commits into from
Sep 14, 2020
Merged

doc: update title of "new bot" dialog #4063

merged 6 commits into from
Sep 14, 2020

Conversation

zxyanliu
Copy link
Contributor

@zxyanliu zxyanliu commented Sep 8, 2020 •
edited by a-b-r-o-w-n
Loading

Description

As an experiment to refine texts in Composer UI.

  • For the new bot project form:
    Create a bot project
    Specify a name, description, and location for your new bot project.

  • For the new dialog form:
    Create a dialog
    Specify a name and description for your new dialog.

Task Item

closes #3952

Screenshots

e2e test in a draft PR:

image

image

image

@boydc2014
Copy link
Contributor

LGTM, @liweitian can you help check this DEFINE_CONVERSATION_OBJECTIVE is used elsewhere, should we just remove it?

@coveralls
Copy link

coveralls commented Sep 8, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 55.494% when pulling 8bc7709 on zxyanliu/title-text/20200904 into f2a365a on main.

@zxyanliu zxyanliu changed the title doc: Update title of "new bot" dialog draft: update title of "new bot" dialog Sep 8, 2020
@liweitian
Copy link
Contributor

LGTM, @liweitian can you help check this DEFINE_CONVERSATION_OBJECTIVE is used elsewhere, should we just remove it?

remove it should be fine. @zxyanliu @boydc2014

@zxyanliu
Copy link
Contributor Author

I reverted the commit to remove DEFINE_CONVERSATION_OBJECTIVE.
Let's not remove it for now.

@zxyanliu zxyanliu changed the title draft: update title of "new bot" dialog doc: update title of "new bot" dialog Sep 10, 2020
@zxyanliu zxyanliu marked this pull request as ready for review September 10, 2020 22:51
@a-b-r-o-w-n
Copy link
Contributor

@zxyanliu will this close #3952?

@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Sep 14, 2020
@zxyanliu
Copy link
Contributor Author

@zxyanliu will this close #3952?

@a-b-r-o-w-n Yes. Thanks!

@a-b-r-o-w-n
Copy link
Contributor

@zxyanliu check out https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

@a-b-r-o-w-n a-b-r-o-w-n merged commit 2315eeb into main Sep 14, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the zxyanliu/title-text/20200904 branch September 14, 2020 16:01
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zxyanliu @a-b-r-o-w-n
doc: update title of "new bot" dialog (microsoft#4063)
9020047 
* draft

* Update constants.ts

* Revert "Update constants.ts"

This reverts commit cd473ff3e410a532cbd200518ced6509c8772852.

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update title of "new bot" dialog
5 participants
@zxyanliu @boydc2014 @coveralls @liweitian @a-b-r-o-w-n