Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix See Log button enable #4056

Merged
merged 4 commits into from
Sep 9, 2020
Merged

fix: fix See Log button enable #4056

merged 4 commits into from
Sep 9, 2020

Conversation

VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Sep 7, 2020

Description

Reason: after user switch profile, selectIndex will be reset to undefined.
Solusion: add onActiveItemChanged function in detailList component to set the selectIndex after clicking.

Task Item

close #4055

Screenshots

image

@VanyLaw VanyLaw changed the title fix see log enable fix: fix See Log button enable Sep 7, 2020
@coveralls
Copy link

coveralls commented Sep 7, 2020

Coverage Status

Coverage decreased (-0.003%) to 55.61% when pulling 4949d01 on wenyluo/fixSeeLog into 5178ffe on main.

@cwhitten cwhitten merged commit 5875b2b into main Sep 9, 2020
@cwhitten cwhitten deleted the wenyluo/fixSeeLog branch September 9, 2020 21:11
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can not see log after clicking publish status.
5 participants