build: fix docker builds in ACR #3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usage: docker build --build-args YARN_ARGS=--verbose .
The packages directory was being ignored in error with the rule `**/es`. That rule is outdated, and removing fixes acr builds.
a-b-r-o-w-n
requested review from
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
|
@kunigagon could you give this a try? I was able to build and push to ACR. |
|
@a-b-r-o-w-n the linked issue is now closed. Do we will want to take this? |
|
Yes. I think it was closed without getting merged. |
cwhitten
approved these changes
Sep 15, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Sep 16, 2020
* main: fix: add more missing formatMessage calls (microsoft#4144) feat: electron splash screen (microsoft#4119) feat: Add QnA files to dispatch model in skill manifest (microsoft#3985) fix: check whether operation is under current project folder (microsoft#4078) update localization and add missing "example" string (microsoft#4138) fix: defense invocation of `value.match()` (microsoft#4110) fix: checkReturnType in ExpressionValidation throws unexpected error (microsoft#4112) chore(deps): Bump tree-kill from 1.2.1 to 1.2.2 in /Composer (microsoft#4035) build: fix docker builds in ACR (microsoft#3986) fix: security: downgrade node-forge to 0.9.0 (microsoft#4133) chore: update archiver to fix security warning (microsoft#4116)
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* allow passing yarn args to docker build usage: docker build --build-args YARN_ARGS=--verbose . * fix acr builds The packages directory was being ignored in error with the rule `**/es`. That rule is outdated, and removing fixes acr builds. Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates .dockerignore to fix ACR builds. Tthe rule
**/eswas working as expected for local builds, but ignoring thepackagesdirectory for ACR builds. It was an outdated rule anyways, so its safe to remove.Task Item
fixes #3945