feat: BotProject File Schema #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
changed the title
srinaath
commented
Sep 17, 2020
srinaath
commented
Sep 24, 2020
tdurnford
reviewed
Sep 28, 2020
tdurnford
reviewed
Sep 28, 2020
…oser into srravich/bot-projects-schema
tdurnford
reviewed
Sep 29, 2020
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
added
BotProjects
srinaath
changed the title
srinaath
requested review from
a-b-r-o-w-n,
beyackle,
tonyanziano,
GeoffCoxMSFT and
hatpick
and removed request for
hatpick,
tonyanziano,
a-b-r-o-w-n and
GeoffCoxMSFT
added 3 commits
October 6, 2020 23:36
…oser into srravich/bot-projects-schema Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/.gitignore
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
requested review from
a-b-r-o-w-n,
boydc2014,
GeoffCoxMSFT,
hatpick and
tonyanziano
as code owners
srinaath
commented
Oct 7, 2020
| "$ref": "#/definitions/skill" | ||
| } | ||
| }, | ||
| "additionalProperties": false |
There was a problem hiding this comment.
{
"patternProperties": {
"^\\$": { "title": "Skill name", "description": "Skill name identifier" }
},
"additionalProperties": { "$ref": "#/definitions/skill" }
}There was a problem hiding this comment.
As per @tdurnford comment
…oser into srravich/bot-projects-schema
…rosoft/BotFramework-Composer into srravich/bot-projects-schema
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
cwhitten
approved these changes
Oct 12, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added schema for bot project support Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Add 1.0 botproject schema Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Fix typo Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated gitignore Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Typo fixed Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Following sdk.schema approach to specificy object type using ref Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.0 Botproject schema.
This schema supports documenting the Root Bot and the skills data that is required to load the family of bots and start runtimes locally (R11). Version 2.0 would support linking to a Publishing Profile which would encapsulate the deployment configurations required per bot.
This schema would be moved into the SDK repo end of R11
Fixes #4162